Changeset 887 for branches/CloningRefactorBranch/HeuristicLab.Logging/Linechart.cs

Timestamp:

12/02/08 21:10:17 (16 years ago)

Author:

gkronber

Message:

Refactored cloning in all plugins except: HL.Communication, HL.Hive, HL.GP, HL.Routing, HL.Scheduling, HL.SimOpt, HL.Visualization

#285 (Cloning could be improved by creating objects at the bottom of the cloning chain with 'new' instead of the top with Activator.CreateInstance())

File:

• branches/CloningRefactorBranch/HeuristicLab.Logging/Linechart.cs (modified) (1 diff)

branches/CloningRefactorBranch/HeuristicLab.Logging/Linechart.cs

@@ -59 +59 @@
     }
 
+    /// <summary>
+    /// Copy constructor to create deep clones.
+    /// </summary>
+    /// <param name="original">The instance to be cloned.</param>
+    public Linechart(Linechart original) : this(original, new Dictionary<Guid, object>()) { }
 
+
+    /// <summary>
+    /// Copy constructor for DistributedEngine clones (deep clone) reusing already cloned object references
+    /// </summary>
+    /// <remarks>Calls the copy constructor of the base class <see cref="EngineBase"/></remarks>
+    /// <param name="original">Instance to be cloned</param>
+    /// <param name="clonedObjects">Already cloned object reference</param>
+    protected Linechart(Linechart original, IDictionary<Guid, object> clonedObjects)
+      : base(original, clonedObjects) {
+      this.myNumberOfLines = (IntData)Auxiliary.Clone(original.myNumberOfLines,clonedObjects);
+      this.myValues = (ItemList)Auxiliary.Clone(original.Values, clonedObjects);
+    }
+
+    /// <summary>
+    /// Creates a deep clone with the copy constructor reusing already cloned
+    /// object references.
+    /// </summary>
+    /// <param name="clonedObjects">Already cloned objects (for referential integrity).</param>
+    /// <returns>The cloned instance.</returns>
     public override object Clone(IDictionary<Guid, object> clonedObjects) {
-      Linechart clone = (Linechart)base.Clone(clonedObjects);
-      clone.myNumberOfLines = (IntData)Auxiliary.Clone(myNumberOfLines, clonedObjects);
-      clone.myValues = (ItemList)Auxiliary.Clone(Values, clonedObjects);
-      return clone;
+      return new Linechart(this, clonedObjects);
     }