Changeset 887 for branches/CloningRefactorBranch/HeuristicLab.Core/OperatorBase.cs

Timestamp:

12/02/08 21:10:17 (16 years ago)

Author:

gkronber

Message:

Refactored cloning in all plugins except: HL.Communication, HL.Hive, HL.GP, HL.Routing, HL.Scheduling, HL.SimOpt, HL.Visualization

#285 (Cloning could be improved by creating objects at the bottom of the cloning chain with 'new' instead of the top with Activator.CreateInstance())

File:

• branches/CloningRefactorBranch/HeuristicLab.Core/OperatorBase.cs (modified) (2 diffs)

branches/CloningRefactorBranch/HeuristicLab.Core/OperatorBase.cs

@@ -105 +105 @@
 
     /// <summary>
-    /// Copy constructor.
-    /// </summary>
-    /// <param name="original">The original instance to be cloned</param>
+    /// Copy constructor to create deep clones reusing already cloned object references.
+    /// </summary>
+    /// <param name="original">The instance to be cloned.</param>
     /// <param name="clonedObjects">Already cloned objects (for referential integrity).</param>
     protected OperatorBase(OperatorBase original, IDictionary<Guid, object> clonedObjects)
@@ -130 +130 @@
     public override IView CreateView() {
       return new OperatorBaseView(this);
+    }
+
+    /// <summary>
+    /// Creates a deep clone with the copy constructor reusing already cloned
+    /// object references.
+    /// </summary>
+    /// <param name="clonedObjects">Already cloned objects (for referential integrity).</param>
+    /// <returns>The cloned instance.</returns>
+    public override object Clone(IDictionary<Guid, object> clonedObjects) {
+      // override clone for all classes inheriting from OperatorBase, so
+      // we don't need to implement Clone() and the copy constructors in
+      // every single operator.
+      return Activator.CreateInstance(this.GetType(), this, clonedObjects);
     }