Changeset 6168 for branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.4/ExperimentManager/RefreshableHiveExperiment.cs

Timestamp:

05/09/11 14:12:10 (13 years ago)

Author:

cneumuel

Message:

#1233

• removed Job-dto objects from slave core (since it stores outdated objects)
• added command textbox to HiveJobView
• improved the way the control buttons behave in HiveJobView
• improved job control (pause and stop is also possible when job is not currently calculating)
• improved gantt chart view (last state log entry is also displayed)
• unified code for downloading jobs between experiment manager and hive engine

File:

• branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.4/ExperimentManager/RefreshableHiveExperiment.cs (modified) (6 diffs)

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.4/ExperimentManager/RefreshableHiveExperiment.cs

@@ -35 +35 @@
     private JobResultPoller jobResultPoller;
     private JobDownloader<ItemJob> jobDownloader = new JobDownloader<ItemJob>(2, 2);
+    private static object locker = new object();
 
     [Storable]
@@ -66 +67 @@
       get { return refreshAutomatically; }
       set {
-        if (refreshAutomatically != value) {
-          refreshAutomatically = value;
-          OnRefreshAutomaticallyChanged();
-        }
-        if (RefreshAutomatically && hiveExperiment.HiveJobs != null && hiveExperiment.HiveJobs.Count > 0 && (jobResultPoller == null || !jobResultPoller.IsPolling)) {
-          StartResultPolling();
-        } else {
-          StopResultPolling();
+        lock (locker) {
+          if (refreshAutomatically != value) {
+            refreshAutomatically = value;
+            OnRefreshAutomaticallyChanged();
+          }
+          if (RefreshAutomatically) {
+            if (hiveExperiment.HiveJobs != null && hiveExperiment.HiveJobs.Count > 0 && (jobResultPoller == null || !jobResultPoller.IsPolling)) {
+              StartResultPolling();
+            }
+          } else {
+            StopResultPolling();
+          }
         }
       }
@@ -156 +161 @@
           // lastJobDataUpdate equals DateTime.MinValue right after it was uploaded. When the first results are polled, this value is updated
           if (lastJobDataUpdate != DateTime.MinValue && lastJobDataUpdate < hj.Job.LastJobDataUpdate) {
-            jobDownloader.DownloadJob(hj.Job.Id, (itemJob) => {
+            jobDownloader.DownloadJob(hj.Job.Id, (id, itemJob, exception) => {
+              if (exception != null) {
+                throw new JobDownloaderException("Downloading job failed.", exception);
+              }
+
               if (itemJob == null) {
                 // something bad happened to this job. bad job, BAAAD job!
@@ -218 +227 @@
       hiveExperiment.ExecutionTime = TimeSpan.FromMilliseconds(hiveExperiment.GetAllHiveJobs().Sum(x => x.Job.ExecutionTime.HasValue ? x.Job.ExecutionTime.Value.TotalMilliseconds : 0));
     }
-
-    public void OnLoaded() {
-      this.UpdateTotalExecutionTime();
-
-      if (hiveExperiment.ExecutionState != ExecutionState.Stopped) {
-        this.RefreshAutomatically = true;
-      }
-    }
     #endregion
 
@@ -235 +236 @@
       hiveExperiment.ModifiedChanged += new EventHandler(hiveExperiment_ModifiedChanged);
       hiveExperiment.IsProgressingChanged += new EventHandler(hiveExperiment_IsProgressingChanged);
+      hiveExperiment.Loaded += new EventHandler(hiveExperiment_Loaded);
     }
 
@@ -244 +246 @@
       hiveExperiment.ModifiedChanged -= new EventHandler(hiveExperiment_ModifiedChanged);
       hiveExperiment.IsProgressingChanged -= new EventHandler(hiveExperiment_IsProgressingChanged);
+      hiveExperiment.Loaded -= new EventHandler(hiveExperiment_Loaded);
+    }
+
+    private void hiveExperiment_Loaded(object sender, EventArgs e) {
+      this.UpdateTotalExecutionTime();
+
+      if (hiveExperiment.ExecutionState != ExecutionState.Stopped) {
+        this.RefreshAutomatically = true;
+      }
     }