Changeset 18056 for branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/JsonItems/ListJsonItem.cs

Timestamp:

09/17/21 16:25:19 (3 years ago)

Author:

dpiringe

Message:

#3026

• fixed a wrong description for the invert parameter in RunCollectionValueRemover
• fixed the usage of a wrong formatter in RunCollectionSRSolutionGraphVizFormatter
• fixed a bug in ListJsonItem where an empty guid field can cause an exception
• started to rework the RegressionProblemDataConverter -> it causes a bug with the symbol Variable of the TypeCorherentGrammar (maybe more grammars)
  • the reasons for the rework: this converter was already the source of some problems in the past; it uses a lot of reflection and dynamic objects -> it is very complicated to read/understand
• added an official description property Description in the metadata part of a template + entry in Constants.cs

File:

• branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/JsonItems/ListJsonItem.cs (modified) (1 diff)

branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/JsonItems/ListJsonItem.cs

@@ -20 +20 @@
 
     public override void SetJObject(JObject jObject) {
-      TargetTypeGUID = jObject[nameof(IListJsonItem.TargetTypeGUID)].ToString();
-      var targetType = Mapper.StaticCache.GetType(new Guid(TargetTypeGUID));
+      var guidJObj = jObject[nameof(IListJsonItem.TargetTypeGUID)];
       IList<IJsonItem> items = new List<IJsonItem>();
-      foreach (JObject obj in jObject[nameof(IValueJsonItem.Value)]) {
-        items.Add((IJsonItem)obj.ToObject(targetType));
+      if (guidJObj != null) {
+        TargetTypeGUID = jObject[nameof(IListJsonItem.TargetTypeGUID)].ToString();
+        var targetType = Mapper.StaticCache.GetType(new Guid(TargetTypeGUID));
+        foreach (JObject obj in jObject[nameof(IValueJsonItem.Value)]) {
+          items.Add((IJsonItem)obj.ToObject(targetType));
+        }
       }
       Value = items.ToArray();