Changeset 18056 for branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/RegressionProblemDataConverter.cs

Timestamp:

09/17/21 16:25:19 (3 years ago)

Author:

dpiringe

Message:

#3026

• fixed a wrong description for the invert parameter in RunCollectionValueRemover
• fixed the usage of a wrong formatter in RunCollectionSRSolutionGraphVizFormatter
• fixed a bug in ListJsonItem where an empty guid field can cause an exception
• started to rework the RegressionProblemDataConverter -> it causes a bug with the symbol Variable of the TypeCorherentGrammar (maybe more grammars)
  • the reasons for the rework: this converter was already the source of some problems in the past; it uses a lot of reflection and dynamic objects -> it is very complicated to read/understand
• added an official description property Description in the metadata part of a template + entry in Constants.cs

File:

• branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/RegressionProblemDataConverter.cs (modified) (2 diffs)

branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/RegressionProblemDataConverter.cs

@@ -28 +28 @@
     #endregion
 
-    public override int Priority => 20;
-
-    public override bool CanConvertType(Type t) =>
-      HEAL.Attic.Mapper.StaticCache.GetType(new Guid("EE612297-B1AF-42D2-BF21-AF9A2D42791C")).IsAssignableFrom(t);
+    public override int Priority => 20;//20;
+
+    public override bool CanConvertType(Type t) => t == typeof(ValueParameter<IRegressionProblemData>);
+      //HEAL.Attic.Mapper.StaticCache.GetType(new Guid("EE612297-B1AF-42D2-BF21-AF9A2D42791C")).IsAssignableFrom(t); // IRegressionProblemData
 
     public override void Inject(IItem item, IJsonItem data, IJsonItemConverter root) {
+
+      var tmp = item as IRegressionProblemData; //ModifiableDataset
+      //tmp.InputVariables
+      
 
       dynamic regressionProblemData = (dynamic)item;
@@ -141 +145 @@
     private void SetAllowedInputVariables(dynamic regressionProblemData, StringArrayJsonItem item, IMatrixJsonItem matrix) {
       if (item != null && regressionProblemData is IParameterizedItem p) {
+        
         var regProbDataType = ((ParameterizedNamedItem)regressionProblemData).GetType(); //RegressionProblemData