Changeset 17483 for branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/JsonItemConverter.cs

Timestamp:

03/23/20 11:58:38 (4 years ago)

Author:

dpiringe

Message:

#3026:

• added readme JsonInterfaceReadMe.txt
• removed dead code
• fixed a bug in JsonItemConverter -> now the type comparison should work as intended

File:

• branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/JsonItemConverter.cs (modified) (1 diff)

branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/JsonItemConverter.cs

@@ -93 +93 @@
 
     private bool CompareGenericTypes(Type t1, Type t2) =>
-      (t1.IsGenericType && t1.GetGenericTypeDefinition() == t2) ||
-      (t2.IsGenericType && t2.GetGenericTypeDefinition() == t1);
+      (t1.IsGenericType && t1.GetGenericTypeDefinition() == t2) /*||
+      (t2.IsGenericType && t2.GetGenericTypeDefinition() == t1)*/;
 
     private bool CompareTypes(Type t1, Type t2) =>
-      t1 == t2 || t1.IsAssignableFrom(t2) ||
+      t1 == t2 || /*t1.IsAssignableFrom(t2) ||*/
       t1.GetInterfaces().Any(
         i => i == t2 || CompareGenericTypes(i, t2)