Changeset 17481 for branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Models/IntervalRestrictedArrayJsonItem.cs

Timestamp:

03/17/20 17:03:24 (4 years ago)

Author:

dpiringe

Message:

#3026:

• refactored json item validation process -> every method now returns a ValidationResult containing bool Success (true if validation is successful) and IEnumerable<string> Errors (error messages)
  • this design allows to specify error messages directly in json items

File:

• branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Models/IntervalRestrictedArrayJsonItem.cs (modified) (1 diff)

branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Models/IntervalRestrictedArrayJsonItem.cs

@@ -12 +12 @@
     public T Maximum { get; set; }
 
-    protected override bool Validate() {
-      foreach(var x in Value) {
-        if (Minimum.CompareTo(x) > 0 || Maximum.CompareTo(x) < 0)
-          return false;
+    protected override ValidationResult Validate() {
+      IList<string> errors = new List<string>();
+      bool success = true;
+      foreach (var x in Value) {
+        if (Minimum.CompareTo(x) > 0 && Maximum.CompareTo(x) < 0) {
+          success = false;
+          errors.Add($"[{Path}]: Value {x} is not between {Minimum} and {Maximum}.");
+        }
       }
-      return true;
+      return new ValidationResult(success, errors);
     }