Changeset 17481 for branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface.OptimizerIntegration/Views/ExportJsonDialog.cs

Timestamp:

03/17/20 17:03:24 (4 years ago)

Author:

dpiringe

Message:

#3026:

• refactored json item validation process -> every method now returns a ValidationResult containing bool Success (true if validation is successful) and IEnumerable<string> Errors (error messages)
  • this design allows to specify error messages directly in json items

File:

• branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface.OptimizerIntegration/Views/ExportJsonDialog.cs (modified) (1 diff)

branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface.OptimizerIntegration/Views/ExportJsonDialog.cs

@@ -69 +69 @@
       // clear all runs
       Optimizer.Runs.Clear();
-      
-      IList<IJsonItem> faultyItems = new List<IJsonItem>();
-      
-      if (!Root.GetValidator().Validate(ref faultyItems)) {
+
+      var validationResult = Root.GetValidator().Validate();
+      if (!validationResult.Success) {
         IList<Exception> list = new List<Exception>();
         //print faultyItems
-        foreach (var x in faultyItems) {
-          list.Add(new Exception($"Combination of value and range is not valid for {x.Name}"));
+        foreach (var x in validationResult.Errors) {
+          list.Add(new Exception(x));
         }
         ErrorHandling.ShowErrorDialog(this, new AggregateException(list));