Changeset 17374 for branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/BaseConverter.cs

Timestamp:

12/06/19 14:39:00 (4 years ago)

Author:

dpiringe

Message:

#3026:

• extended the BaseConverter class to set the type of the extracted value and removed the assignment of type in all other converters
• fixed a bug in ConfigurableConverter -> now it correctly iterates through all items from an IEnumerable and calls the extract callback
• MultiCheckedOperatorConverter:
  • deleted unnecessary code line
  • now adds operators to parameters (instead of operator list, because the operator list will get removed in a future commit)
  • does not set the path of its added items anymore
• ParameterBaseConverter removed unnecessary code lines
• deleted ParameterBaseConverter
• reimplemented StorableConverter to test it again (still not really useable, because it bloats the template massively)
• fixed a pathing bug in ValueParameterConverter (extended ValueRangeConverter, ValueTypeArrayConverter, ValueTypeMatrixConverter, ValueTypeValueConverter to archive this)
• JCGenerator now only writes a single array with parameters (only FreeParameters) and saves a .hl File to test a new type of implementation of the whole JsonInterface
• fixed a bug in JsonItem -> now it replaces the name in path of the item (not the whole path as it was before)

File:

• branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/BaseConverter.cs (modified) (2 diffs)

branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/BaseConverter.cs

@@ -20 +20 @@
     public JsonItem Extract(IItem value) {
       JsonItem data = ExtractData(value);
-      data.Name = String.IsNullOrEmpty(data.Name) ? value.ItemName : data.Name;
+      data.Name = string.IsNullOrEmpty(data.Name) ? value.ItemName : data.Name;
+      data.Type = string.IsNullOrEmpty(data.Type) ? value.GetType().AssemblyQualifiedName : data.Type;
       return data;
     }
@@ -87 +88 @@
     protected object GetDefaultValue(Type t) => t.IsValueType ? Activator.CreateInstance(t) : null;
 
-    
-
     #endregion
   }