Changeset 17314 for branches/2994-AutoDiffForIntervals/HeuristicLab.Problems.DataAnalysis.Symbolic/3.4/Interpreter/AlgebraicInterval.cs

Timestamp:

10/04/19 10:40:51 (5 years ago)

Author:

gkronber

Message:

#2994: fix bug in calculation of cos() and sin()

File:

• branches/2994-AutoDiffForIntervals/HeuristicLab.Problems.DataAnalysis.Symbolic/3.4/Interpreter/AlgebraicInterval.cs (modified) (4 diffs)

branches/2994-AutoDiffForIntervals/HeuristicLab.Problems.DataAnalysis.Symbolic/3.4/Interpreter/AlgebraicInterval.cs

@@ -9 +9 @@
   [DebuggerDisplay("[{low.Value}..{high.Value}]")]
   public class AlgebraicInterval : IAlgebraicType<AlgebraicInterval> {
+
+    // turn a double into an interval (of size 0)
+    public static implicit operator AlgebraicInterval(double value) { return new AlgebraicInterval(value, value); }
+
     [DebuggerBrowsable(DebuggerBrowsableState.Never)]
     private MultivariateDual<AlgebraicDouble> low;
@@ -193 +197 @@
     }
 
+
+    // TODO: move to constants
+    private const double pi_2 = Math.PI / 2.0;
+    private static readonly double[] maxima = new double[] { -3 * pi_2, pi_2, 5 * pi_2 };
+    private static readonly double[] minima = new double[] { -5 * pi_2, -pi_2, 3 * pi_2 };
+
     public AlgebraicInterval AssignSin(AlgebraicInterval a) {
       var lower = a.LowerBound.Value.Value;
@@ -213 +223 @@
 
       // handle min = -1 and max = 1 cases explicitly
-      var pi_2 = Math.PI / 2.0;
-      var maxima = new double[] { -3 * pi_2, pi_2 };
-      var minima = new double[] { -pi_2, 3 * pi_2 };
 
       // override min and max if necessary
@@ -294 +301 @@
       if (xs.Length <= 2) throw new ArgumentException("need at least 3 arguments");
       AssignLowAndHigh(xs[0], xs[1]);
-      for(int i=2;i<xs.Length;i++) {
+      for (int i = 2; i < xs.Length; i++) {
         // we must make sure that low and high are different objects when a == b
         if (low.Value.CompareTo(xs[i].Value) > 0) low.Assign(xs[i]);