Changeset 16469 for misc/tools/PersistenceCodeFix/PersistenceCodeFix/PersistenceCodeFix/Analyzers/MissingStorableConstructor/MissingStorableConstructorAnalyzer.cs

Timestamp:

12/29/18 21:13:46 (5 years ago)

Author:

gkronber

Message:

#2520: Adapted VS code fixes:

• using HeuristicLab.Persistence -> using HEAL.Fossil
• Made missing StorableCtor a Warning
• Ignore StorableCtor for structs and interfaces

File:

• misc/tools/PersistenceCodeFix/PersistenceCodeFix/PersistenceCodeFix/Analyzers/MissingStorableConstructor/MissingStorableConstructorAnalyzer.cs (modified) (2 diffs)

misc/tools/PersistenceCodeFix/PersistenceCodeFix/PersistenceCodeFix/Analyzers/MissingStorableConstructor/MissingStorableConstructorAnalyzer.cs

@@ -14 +14 @@
     private const string Category = nameof(DiagnosticCategory.Persistence);
 
-    private static DiagnosticDescriptor Rule = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true, description: Description);
+    private static DiagnosticDescriptor Rule = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get { return ImmutableArray.Create(Rule); } }
@@ -25 +25 @@
       var namedTypeSymbol = (INamedTypeSymbol)context.Symbol;
       if (namedTypeSymbol.IsStatic) return;
-      if (namedTypeSymbol.TypeKind == TypeKind.Delegate || namedTypeSymbol.TypeKind == TypeKind.Enum) return;
+      if (namedTypeSymbol.TypeKind == TypeKind.Delegate || namedTypeSymbol.TypeKind == TypeKind.Enum || namedTypeSymbol.TypeKind == TypeKind.Struct || namedTypeSymbol.TypeKind == TypeKind.Interface) return;
 
       var attr = context.Symbol.GetAttributes();