Changeset 16469

Timestamp:

12/29/18 21:13:46 (5 years ago)

Author:

gkronber

Message:

#2520: Adapted VS code fixes:

• using HeuristicLab.Persistence -> using HEAL.Fossil
• Made missing StorableCtor a Warning
• Ignore StorableCtor for structs and interfaces

Location:

misc/tools/PersistenceCodeFix/PersistenceCodeFix

Files:

• PersistenceCodeFix.Vsix/PersistenceCodeFix.Vsix.csproj (modified) (1 diff)
• PersistenceCodeFix/Analyzers/MissingStorableConstructor/MissingStorableConstructorAnalyzer.cs (modified) (2 diffs)
• PersistenceCodeFix/Analyzers/MissingStorableType/MissingStorableTypeFix.cs (modified) (1 diff)
• PersistenceCodeFix/Analyzers/ObsoleteStorableClass/ObsoleteStorableClassFix.cs (modified) (1 diff)

misc/tools/PersistenceCodeFix/PersistenceCodeFix/PersistenceCodeFix.Vsix/PersistenceCodeFix.Vsix.csproj

@@ -3 +3 @@
 <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
-    <MinimumVisualStudioVersion>14.0</MinimumVisualStudioVersion>
+    <MinimumVisualStudioVersion>15.0</MinimumVisualStudioVersion>
     <VSToolsPath Condition="'$(VSToolsPath)' == ''">$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)</VSToolsPath>
+    <FileUpgradeFlags>
+    </FileUpgradeFlags>
+    <UpgradeBackupLocation>
+    </UpgradeBackupLocation>
+    <OldToolsVersion>14.0</OldToolsVersion>
   </PropertyGroup>
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />

misc/tools/PersistenceCodeFix/PersistenceCodeFix/PersistenceCodeFix/Analyzers/MissingStorableConstructor/MissingStorableConstructorAnalyzer.cs

@@ -14 +14 @@
     private const string Category = nameof(DiagnosticCategory.Persistence);
 
-    private static DiagnosticDescriptor Rule = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Error, isEnabledByDefault: true, description: Description);
+    private static DiagnosticDescriptor Rule = new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, Category, DiagnosticSeverity.Warning, isEnabledByDefault: true, description: Description);
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics { get { return ImmutableArray.Create(Rule); } }
@@ -25 +25 @@
       var namedTypeSymbol = (INamedTypeSymbol)context.Symbol;
       if (namedTypeSymbol.IsStatic) return;
-      if (namedTypeSymbol.TypeKind == TypeKind.Delegate || namedTypeSymbol.TypeKind == TypeKind.Enum) return;
+      if (namedTypeSymbol.TypeKind == TypeKind.Delegate || namedTypeSymbol.TypeKind == TypeKind.Enum || namedTypeSymbol.TypeKind == TypeKind.Struct || namedTypeSymbol.TypeKind == TypeKind.Interface) return;
 
       var attr = context.Symbol.GetAttributes();

misc/tools/PersistenceCodeFix/PersistenceCodeFix/PersistenceCodeFix/Analyzers/MissingStorableType/MissingStorableTypeFix.cs

@@ -100 +100 @@
       var newRoot = root.ReplaceNode(baseTypeDecl, newBaseTypeDecl);
 
-      // add using of HeuristicLab.Persistence if the document does not already have it 
+      // add using of HEAL.Fossil if the document does not already have it 
       var oldUsings = root.Usings;
-      if (oldUsings.All(x => x.Name.WithoutTrivia().ToString() != "HeuristicLab.Persistence")) {
-        var persistenceUsing = SyntaxFactory.UsingDirective(SyntaxFactory.IdentifierName("HeuristicLab.Persistence"));
+      if (oldUsings.All(x => x.Name.WithoutTrivia().ToString() != "HEAL.Fossil")) {
+        var persistenceUsing = SyntaxFactory.UsingDirective(SyntaxFactory.IdentifierName("HEAL.Fossil"));
         newRoot = newRoot.WithUsings(oldUsings.Add(persistenceUsing));
       }

misc/tools/PersistenceCodeFix/PersistenceCodeFix/PersistenceCodeFix/Analyzers/ObsoleteStorableClass/ObsoleteStorableClassFix.cs

@@ -82 +82 @@
       var newRoot = root.ReplaceNode(attrDecl, newAttrDecl);
 
-      // add using of HeuristicLab.Persistence if the document does not already have it 
+      // add using of HEAL.Fossil if the document does not already have it 
       var oldUsings = root.Usings;
-      if (oldUsings.All(x => x.Name.WithoutTrivia().ToString() != "HeuristicLab.Persistence")) {
-        var persistenceUsing = SyntaxFactory.UsingDirective(SyntaxFactory.IdentifierName("HeuristicLab.Persistence"));
+      if (oldUsings.All(x => x.Name.WithoutTrivia().ToString() != "HEAL.Fossil")) {
+        var persistenceUsing = SyntaxFactory.UsingDirective(SyntaxFactory.IdentifierName("HEAL.Fossil"));
         newRoot = newRoot.WithUsings(oldUsings.Add(persistenceUsing));
       }