Free cookie consent management tool by TermsFeed Policy Generator

Ignore:
Timestamp:
02/26/18 14:13:32 (6 years ago)
Author:
fholzing
Message:

#2904: Cleaned up the method signature (some optional parameters aren't so optional)

File:
1 edited

Legend:

Unmodified
Added
Removed
  • branches/2904_CalculateImpacts/3.4/Implementation/Regression/RegressionSolutionVariableImpactsCalculator.cs

    r15815 r15816  
    172172    public static double CalculateImpact(string variableName,
    173173      IRegressionSolution solution,
     174      IEnumerable<int> rows,
     175      IEnumerable<double> targetValues,
     176      double originalR2,
    174177      DataPartitionEnum data = DataPartitionEnum.Training,
    175178      ReplacementMethodEnum replacementMethod = ReplacementMethodEnum.Median,
    176       FactorReplacementMethodEnum factorReplacementMethod = FactorReplacementMethodEnum.Best,
    177       IEnumerable<int> rows = null,
    178       IEnumerable<double> targetValues = null,
    179     double originalR2 = -1) {
     179      FactorReplacementMethodEnum factorReplacementMethod = FactorReplacementMethodEnum.Best) {
    180180
    181181      double impact = 0;
     
    219219          if (progressCallback((double)curIdx / count, string.Format("Calculating impact for variable {0} ({1} of {2})", inputVariable, curIdx, count))) { return null; }
    220220        }
    221         impacts[inputVariable] = CalculateImpact(inputVariable, solution, data, replacementMethod, factorReplacementMethod, rows, targetValues, originalR2);
     221        impacts[inputVariable] = CalculateImpact(inputVariable, solution, rows, targetValues, originalR2, data, replacementMethod, factorReplacementMethod);
    222222      }
    223223
Note: See TracChangeset for help on using the changeset viewer.