Changeset 15619

Timestamp:

01/16/18 16:56:13 (6 years ago)

Author:

bburlacu

Message:

#2879: Performance improvement in DataTableView

File:

• trunk/sources/HeuristicLab.Analysis.Views/3.3/DataTableView.cs (modified) (10 diffs)

trunk/sources/HeuristicLab.Analysis.Views/3.3/DataTableView.cs

@@ -398 +398 @@
         DataRow row = (DataRow)sender;
         Series series = chart.Series[row.Name];
-        series.Points.Clear();
+        ClearPoints(series.Points);
         ConfigureSeries(series, row);
         if (!invisibleSeries.Contains(series)) {
@@ -426 +426 @@
           Series rowSeries = chart.Series[row.Name];
           if (!invisibleSeries.Contains(rowSeries)) {
-            rowSeries.Points.Clear();
+            ClearPoints(rowSeries.Points);
             FillSeriesWithRowValues(rowSeries, row);
             RecalculateAxesScale(chart.ChartAreas[0]);
@@ -443 +443 @@
           Series rowSeries = chart.Series[row.Name];
           if (!invisibleSeries.Contains(rowSeries)) {
-            rowSeries.Points.Clear();
+            ClearPoints(rowSeries.Points);
             FillSeriesWithRowValues(rowSeries, row);
             RecalculateAxesScale(chart.ChartAreas[0]);
@@ -461 +461 @@
           if (!invisibleSeries.Contains(rowSeries)) {
             if (row.VisualProperties.ChartType == DataRowVisualProperties.DataRowChartType.Histogram) {
-              rowSeries.Points.Clear();
+              ClearPoints(rowSeries.Points);
               FillSeriesWithRowValues(rowSeries, row);
             } else {
@@ -488 +488 @@
           Series rowSeries = chart.Series[row.Name];
           if (!invisibleSeries.Contains(rowSeries)) {
-            rowSeries.Points.Clear();
+            ClearPoints(rowSeries.Points);
             FillSeriesWithRowValues(rowSeries, row);
             RecalculateAxesScale(chart.ChartAreas[0]);
@@ -506 +506 @@
           Series rowSeries = chart.Series[row.Name];
           if (!invisibleSeries.Contains(rowSeries)) {
-            rowSeries.Points.Clear();
+            ClearPoints(rowSeries.Points);
             FillSeriesWithRowValues(rowSeries, row);
             RecalculateAxesScale(chart.ChartAreas[0]);
@@ -549 +549 @@
     private void ToggleSeriesVisible(Series series) {
       if (!invisibleSeries.Contains(series)) {
-        series.Points.Clear();
+        ClearPoints(series.Points);
         invisibleSeries.Add(series);
       } else {
@@ -580 +580 @@
                             where !invisibleSeries.Contains(s)
                             select new { row = r, series = s }) {
-            h.series.Points.Clear();
+            ClearPoints(h.series.Points);
             CalculateHistogram(h.series, h.row, histograms);
           }
@@ -607 +607 @@
 
     protected virtual void CalculateHistogram(Series series, DataRow row, IEnumerable<DataRow> histogramRows) {
-      series.Points.Clear();
+      ClearPoints(series.Points);
       if (!row.Values.Any()) return;
 
@@ -740 +740 @@
       return double.IsNaN(x) || x < (double)decimal.MinValue || x > (double)decimal.MaxValue;
     }
+
+    // workaround for performance problem as described in https://stackoverflow.com/questions/5744930/datapointcollection-clear-performance
+    public static void ClearPoints(DataPointCollection points) {
+      points.SuspendUpdates();
+      while (points.Count > 0)
+        points.RemoveAt(points.Count - 1);
+      points.ResumeUpdates();
+    }
     #endregion
   }