Changeset 15489 for branches/DataPreprocessing Cleanup/HeuristicLab.DataPreprocessing.Views/3.4/FilterView.cs

Timestamp:

11/30/17 10:31:27 (6 years ago)

Author:

pfleck

Message:

#2809:

• Fixed wrong number of remaining/toral rows after filter changed
• Improved performance for filtering as suggested by bburlacu. Thanks for the patch.
• Start all charts with index zero.

File:

• branches/DataPreprocessing Cleanup/HeuristicLab.DataPreprocessing.Views/3.4/FilterView.cs (modified) (1 diff)

branches/DataPreprocessing Cleanup/HeuristicLab.DataPreprocessing.Views/3.4/FilterView.cs

@@ -71 +71 @@
       applyFilterButton.Enabled = activeFilters;
 
+      Content.PreprocessingData.ResetFilter();
+
       int numTotal = Content.PreprocessingData.Rows;
       int numRemaining = numTotal;
 
-      Content.PreprocessingData.ResetFilter();
       if (activeFilters) {
         var remainingRows = Content.GetRemainingRows();
-        Content.PreprocessingData.SetFilter(remainingRows);
         numRemaining = remainingRows.Count(x => x);
+
+        if (numRemaining < numTotal) {
+          Content.PreprocessingData.SetFilter(remainingRows);
+        }
       }