Changeset 14996 for branches/DataPreprocessing Enhancements/HeuristicLab.DataPreprocessing.Views/3.4/HistogramView.cs

Timestamp:

05/18/17 12:29:59 (7 years ago)

Author:

pfleck

Message:

#2709

• Fixed initial selection of the grouping text box (empty string instead of null to select the first entry).
• General code fixes (removed unnessecary bank lines and code, class member order, ...)

File:

• branches/DataPreprocessing Enhancements/HeuristicLab.DataPreprocessing.Views/3.4/HistogramView.cs (modified) (3 diffs)

branches/DataPreprocessing Enhancements/HeuristicLab.DataPreprocessing.Views/3.4/HistogramView.cs

@@ -28 +28 @@
   [Content(typeof(HistogramContent), true)]
   public partial class HistogramView : PreprocessingChartView {
-
     public new HistogramContent Content {
       get { return (HistogramContent)base.Content; }
@@ -44 +43 @@
     protected override void OnContentChanged() {
       base.OnContentChanged();
-      classifierComboBox.Items.Clear();
-      classifierComboBox.Items.Add("");
+      groupingComboBox.Items.Clear();
+      groupingComboBox.Items.Add(string.Empty);
 
       if (Content != null) {
         foreach (string var in PreprocessingChartContent.GetVariableNamesForGrouping(Content.PreprocessingData)) {
-          classifierComboBox.Items.Add(var);
+          groupingComboBox.Items.Add(var);
         }
 
-        classifierComboBox.SelectedItem = Content.GroupingVariableName;
+        groupingComboBox.SelectedItem = Content.GroupingVariableName ?? string.Empty;
       }
     }
@@ -62 +61 @@
 
     private void classifierComboBox_SelectedIndexChanged(object sender, EventArgs e) {
-      Content.GroupingVariableName = classifierComboBox.SelectedItem.ToString();
+      Content.GroupingVariableName = groupingComboBox.SelectedItem.ToString();
 
       // rebuild datatables