Changeset 1354 for branches/New Persistence Exploration/Persistence/Persistence/Decomposers.cs

Timestamp:

03/18/09 11:48:30 (15 years ago)

Author:

epitzer

Message:

minor code cleanup.

File:

• branches/New Persistence Exploration/Persistence/Persistence/Decomposers.cs (modified) (5 diffs)

branches/New Persistence Exploration/Persistence/Persistence/Decomposers.cs

@@ -5 +5 @@
 namespace Persistence {
   
+
   public interface IDecomposer {
     bool CanSerialize(Type type);
-    IEnumerable Serialize(object o);
-    object DeSerialize(IEnumerable o, Type t);
+    IEnumerable Serialize(object obj);
+    object DeSerialize(IEnumerable objects, Type type);
   }
 
+
   public class EnumerableDecomposer : IDecomposer {
+
     public bool CanSerialize(Type type) {
-      if (type.GetInterface("IEnumerable") == null)
-        return false;
-      if (type.GetMethod("GetEnumerator", new Type[] { }) == null)
-        return false;
+      return
+        type.GetInterface("IEnumerable") != null &&
+        type.GetMethod("Add") != null &&
+        type.GetMethod("Add").GetParameters().Length == 1 &&
+        type.GetConstructor(
+          BindingFlags.Public |
+          BindingFlags.NonPublic |
+          BindingFlags.Instance,
+          null, Type.EmptyTypes, null) != null;        
+    }    
+
+    public IEnumerable Serialize(object obj) {
+      return (IEnumerable)obj;
+    }
+
+    public object DeSerialize(IEnumerable objects, Type type) {
+      object instance = Activator.CreateInstance(type, true);
       MethodInfo addMethod = type.GetMethod("Add");
-      if (addMethod == null)
-        return false;
-      if (addMethod.GetParameters().Length != 1)
-        return false;
-      return true;
-    }
-    public IEnumerable Serialize(object o) {
-      return (IEnumerable)o;
-    }
-    public object DeSerialize(IEnumerable objects, Type t) {
-      object instance = Activator.CreateInstance(t, true);
       foreach (object o in objects) {
-        t.GetMethod("Add").Invoke(instance, new[] { o });
+        addMethod.Invoke(instance, new[] {o});        
       }
       return instance;
     }
+
   }
 
+
   public class ArrayDecomposer : IDecomposer {
+
     public bool CanSerialize(Type type) {
       return type.IsArray || type == typeof(Array);
     }
+
     public IEnumerable Serialize(object array) {
       Array a = (Array)array;
@@ -50 +59 @@
       }
     }
+
     public object DeSerialize(IEnumerable elements, Type t) {
       IEnumerator e = elements.GetEnumerator();
@@ -77 +87 @@
   }
 
+
   public class KeyValuePairDecomposer : IDecomposer {    
-    public bool CanSerialize(Type type) {      
+
+    public bool CanSerialize(Type type) {
       return type.IsGenericType &&
-        type.GetGenericTypeDefinition().Name == "KeyValuePair`2";
+             type.GetGenericTypeDefinition() == 
+             typeof (KeyValuePair<int, int>).GetGenericTypeDefinition();
     }
+
     public IEnumerable Serialize(object o) {      
       Type t = o.GetType();
@@ -87 +101 @@
       yield return t.GetProperty("Value").GetValue(o, null);
     }
+
     public object DeSerialize(IEnumerable o, Type t) {      
       return Activator.CreateInstance(t,
@@ -92 +107 @@
     }    
   }
+
 
   public class DictionaryDecomposer : IDecomposer {