Changeset 13470 for branches/PTSP/HeuristicLab.Problems.PTSP/3.3/Moves/AnalyticalPTSPMoveEvaluator.cs

Timestamp:

12/15/15 16:38:08 (9 years ago)

Author:

abeham

Message:

#2221:

• implemented review comments
  • hid rng as private class, implemented djb2 hash function (hash function implementation may also change)
  • added missing probabilities
  • base class for instance providers
  • prebuild event events
  • build platforms
  • unit test will be removed on trunk integration
  • corrected assembly file version
  • distance calculator parameter was not hidden, can be changed by user, updates distance matrix
  • fixed performance problems (ouch!) also for estimated ptsp (inlined GetDistance method)
• added moves (full evaluation) for analytical tsp
• added local improvement operators for analytical ptsp
• added recalculation of distance matrix when parameters change
• still lots of other changes

File:

• branches/PTSP/HeuristicLab.Problems.PTSP/3.3/Moves/AnalyticalPTSPMoveEvaluator.cs (copied) (copied from branches/PTSP/HeuristicLab.Problems.PTSP/3.3/Moves/EstimatedPTSPMoveEvaluator.cs) (5 diffs)

branches/PTSP/HeuristicLab.Problems.PTSP/3.3/Moves/AnalyticalPTSPMoveEvaluator.cs

@@ -30 +30 @@
 
 namespace HeuristicLab.Problems.PTSP {
-  [Item("EstimatedPTSPMoveEvaluator", "A base class for operators which evaluate TSP moves.")]
+  [Item("AnalyticalPTSPMoveEvaluator", "A base class for operators which evaluate PTSP moves.")]
   [StorableClass]
-  public abstract class EstimatedPTSPMoveEvaluator : SingleSuccessorOperator, IEstimatedPTSPMoveEvaluator {
+  public abstract class AnalyticalPTSPMoveEvaluator : SingleSuccessorOperator, IAnalyticalPTSPMoveEvaluator {
 
     public override bool CanChangeName {
@@ -50 +50 @@
       get { return (ILookupParameter<BoolValue>)Parameters["UseDistanceMatrix"]; }
     }
-    public ILookupParameter<ItemList<BoolArray>> RealizationsParameter {
-      get { return (ILookupParameter<ItemList<BoolArray>>)Parameters["Realizations"]; }
+    public ILookupParameter<DoubleArray> ProbabilitiesParameter {
+      get { return (ILookupParameter<DoubleArray>)Parameters["Probabilities"]; }
     }
     public ILookupParameter<DoubleValue> QualityParameter {
@@ -64 +64 @@
 
     [StorableConstructor]
-    protected EstimatedPTSPMoveEvaluator(bool deserializing) : base(deserializing) { }
-    protected EstimatedPTSPMoveEvaluator(EstimatedPTSPMoveEvaluator original, Cloner cloner) : base(original, cloner) { }
-    protected EstimatedPTSPMoveEvaluator()
+    protected AnalyticalPTSPMoveEvaluator(bool deserializing) : base(deserializing) { }
+    protected AnalyticalPTSPMoveEvaluator(AnalyticalPTSPMoveEvaluator original, Cloner cloner) : base(original, cloner) { }
+    protected AnalyticalPTSPMoveEvaluator()
       : base() {
       Parameters.Add(new LookupParameter<Permutation>("Permutation", "The solution as permutation."));
@@ -72 +72 @@
       Parameters.Add(new LookupParameter<DistanceMatrix>("DistanceMatrix", "The matrix which contains the distances between the cities."));
       Parameters.Add(new LookupParameter<BoolValue>("UseDistanceMatrix", "True if a distance matrix should be calculated (if it does not exist already) and used for evaluation, otherwise false."));
-      Parameters.Add(new LookupParameter<ItemList<BoolArray>>("Realizations", "The list of samples drawn from all possible stochastic instances."));
+      Parameters.Add(new LookupParameter<DoubleArray>("Probabilities", "The list of probabilities for each city to appear."));
       Parameters.Add(new LookupParameter<DoubleValue>("Quality", "The quality of a TSP solution."));
       Parameters.Add(new LookupParameter<DoubleValue>("MoveQuality", "The evaluated quality of a move on a TSP solution."));
@@ -81 +81 @@
       var permutation = PermutationParameter.ActualValue;
       var coordinates = CoordinatesParameter.ActualValue;
-      double relativeQualityDifference = 0;
+      var probabilities = ProbabilitiesParameter.ActualValue;
+      Func<int, int, double> distance = null;
       if (UseDistanceMatrixParameter.ActualValue.Value) {
         var distanceMatrix = DistanceMatrixParameter.ActualValue;
         if (distanceMatrix == null) throw new InvalidOperationException("The distance matrix has not been calculated.");
-        relativeQualityDifference = EvaluateByDistanceMatrix(permutation, distanceMatrix);
+        distance = (a, b) => distanceMatrix[a, b];
       } else {
         if (coordinates == null) throw new InvalidOperationException("No coordinates were given.");
         var distanceCalculator = DistanceCalculatorParameter.ActualValue;
         if (distanceCalculator == null) throw new InvalidOperationException("Distance calculator is null!");
-        relativeQualityDifference = EvaluateByCoordinates(permutation, coordinates, distanceCalculator);
+        distance = (a, b) => distanceCalculator.Calculate(a, b, coordinates);
       }
+      // here moves are not delta-evaluated
+      var newQuality = EvaluateMove(permutation, distance, probabilities);
       var moveQuality = MoveQualityParameter.ActualValue;
-      if (moveQuality == null) MoveQualityParameter.ActualValue = new DoubleValue(QualityParameter.ActualValue.Value + relativeQualityDifference);
-      else moveQuality.Value = QualityParameter.ActualValue.Value + relativeQualityDifference;
+      if (moveQuality == null) MoveQualityParameter.ActualValue = new DoubleValue(newQuality);
+      else moveQuality.Value = newQuality;
+
       return base.Apply();
     }
 
-    protected abstract double EvaluateByDistanceMatrix(Permutation permutation, DistanceMatrix distanceMatrix);
-    protected abstract double EvaluateByCoordinates(Permutation permutation, DoubleMatrix coordinates, DistanceCalculator distanceCalculator);
+    protected abstract double EvaluateMove(Permutation permutation, Func<int, int, double> distance, DoubleArray probabilities);
   }
 }