Changeset 1340 for trunk/sources/HeuristicLab.Hive.Client.Core/Core.cs

Timestamp:

03/13/09 11:59:36 (15 years ago)

Author:

kgrading

Message:

Code Review changes (#522)

File:

• trunk/sources/HeuristicLab.Hive.Client.Core/Core.cs (modified) (7 diffs)

trunk/sources/HeuristicLab.Hive.Client.Core/Core.cs

@@ -52 +52 @@
   public class Core: MarshalByRefObject {
     public delegate string GetASnapshotDelegate();
-
+    //Todo: private + getter/setter removen.
     public static Object Locker { get; set; }
-
+    //Todo: ev. Rename to "abortRequested"
     public static bool ShutdownFlag { get; set; }
-
+    
+    //Todo: Access modifier
     Dictionary<long, Executor> engines = new Dictionary<long, Executor>();
     Dictionary<long, AppDomain> appDomains = new Dictionary<long, AppDomain>();
@@ -98 +99 @@
       MessageQueue queue = MessageQueue.GetInstance();
       
-      //Main processing loop
+      //Main processing loop     
+      //Todo: own thread for message handling
       while (!ShutdownFlag) {
         MessageContainer container = queue.GetMessage();
@@ -112 +114 @@
     /// <param name="container">The Container, containing the message</param>
     private void DetermineAction(MessageContainer container) {
+      //Todo: Threads aus Threadpool verwenden
+      
       switch (container.Message) {
         //Server requests to abort a job
@@ -152 +156 @@
     private void GetFinishedJob(object jobId) {
       long jId = (long)jobId;
+      //Todo: Don't return null, throw exception!
       byte[] sJob = engines[jId].GetFinishedJob();
 
@@ -162 +167 @@
           true);
       } else {
+        //Todo: locking
         JobStorrageManager.PersistObjectToDisc(wcfService.ServerIP, wcfService.ServerPort, jId, sJob);
         AppDomain.Unload(appDomains[jId]);
@@ -219 +225 @@
     }
 
+    //Todo: Remove intellgent stuff from the async event and move it to the main thread (message queue)
+    //Todo: Seperate this method into 2: Finished jobs and Snapshots
     void wcfService_SendJobResultCompleted(object sender, SendJobResultCompletedEventArgs e) {
       if (e.Result.Success) {        
@@ -237 +245 @@
         }        
       } else {
+        //Todo: don't Java Style! IT'S EVIL!
         Logging.GetInstance().Error(this.ToString(), "Sending of job " + e.Result.JobId + " failed");
       }
     }
 
+    //Todo: First stop all threads, then terminate
     void wcfService_ServerChanged(object sender, EventArgs e) {
       Logging.GetInstance().Info(this.ToString(), "ServerChanged has been called");