Changeset 13369 for branches/RefactorPluginInfrastructure-2522/HeuristicLab.PluginInfrastructure.UI/AboutDialog.cs

Timestamp:

11/24/15 17:08:43 (8 years ago)

Author:

gkronber

Message:

#2522: improvements to AboutDialog and PluginInformationDialog

File:

• branches/RefactorPluginInfrastructure-2522/HeuristicLab.PluginInfrastructure.UI/AboutDialog.cs (modified) (2 diffs)

branches/RefactorPluginInfrastructure-2522/HeuristicLab.PluginInfrastructure.UI/AboutDialog.cs

@@ -37 +37 @@
     /// </summary>
     /// <param name="plugins">Enumerable of plugins that should be listed.</param>
-    public AboutDialog(IEnumerable<IPluginDescription> plugins) {
+    public AboutDialog(IEnumerable<IPluginDescription> plugins, Assembly mainAssembly) {
       InitializeComponent();
-      var entryAssembly = Assembly.GetEntryAssembly();
-      productTextBox.Text = GetProduct(entryAssembly);
-      versionTextBox.Text = entryAssembly.GetFileVersion();
-      copyrightTextBox.Text = GetCopyright(entryAssembly);
+
+      productTextBox.Text = mainAssembly.GetProduct();
+      versionTextBox.Text = mainAssembly.GetFileVersion();
+      copyrightTextBox.Text = mainAssembly.GetCopyright();
       imageList.Images.Add(Resources.Plugin);
       pictureBox.Image = Resources.HeuristicLabLogo;
@@ -54 +54 @@
     /// </summary>
     public AboutDialog()
-      : this(ApplicationManager.Manager.Plugins) {
-    }
-
-    private ListViewItem CreateListViewItem(IPluginDescription plugin) {
-      ListViewItem item = new ListViewItem(new string[] { plugin.Name, plugin.Version.ToString(), plugin.Description });
-      item.Tag = plugin;
-      item.ImageIndex = 0;
-      return item;
-    }
-
-    private string GetCopyright(Assembly asm) {
-      AssemblyCopyrightAttribute attribute = GetAttribute<AssemblyCopyrightAttribute>(asm);
-      return attribute.Copyright;
-    }
-
-    private string GetProduct(Assembly asm) {
-      AssemblyProductAttribute attribute = GetAttribute<AssemblyProductAttribute>(asm);
-      return attribute.Product;
-    }
-
-    private T GetAttribute<T>(Assembly asm) {
-      return (T)asm.GetCustomAttributes(typeof(T), false).Single();
+      : this(ApplicationManager.Manager.Plugins, typeof(IPluginDescription).Assembly) {
     }
 
     private void okButton_Click(object sender, EventArgs e) {
       Close();
-    }
-
-    private void pluginListView_ItemActivate(object sender, EventArgs e) {
     }