Changeset 12858 for branches/HiveStatistics/sources/HeuristicLab.Services.WebApp.Maintenance/3.3/WebApi/FactClientInfoController.cs

Timestamp:

08/13/15 15:22:51 (9 years ago)

Author:

ascheibe

Message:

#2388

• prevent disposing of hive data context
• more cleanups

File:

• branches/HiveStatistics/sources/HeuristicLab.Services.WebApp.Maintenance/3.3/WebApi/FactClientInfoController.cs (modified) (1 diff)

branches/HiveStatistics/sources/HeuristicLab.Services.WebApp.Maintenance/3.3/WebApi/FactClientInfoController.cs

@@ -36 +36 @@
 
     public DT.FactClientInfo GetFactClientInfo(DateTime start, DateTime end) {
-      using (var pm = PersistenceManager) {
-        var factClientInfo = pm.FactClientInfoDao;
-        var query = factClientInfo.GetAll().Where(x => x.Time >= start && x.Time <= end);
-        return new DT.FactClientInfo {
-          Rows = query.Count(),
-          Clients = query.Select(x => x.ClientId).Distinct().Count()
-        };
-      }
+      var pm = PersistenceManager;
+      var factClientInfo = pm.FactClientInfoDao;
+      var query = factClientInfo.GetAll().Where(x => x.Time >= start && x.Time <= end);
+      return new DT.FactClientInfo {
+        Rows = query.Count(),
+        Clients = query.Select(x => x.ClientId).Distinct().Count()
+      };
     }
 
     public void Aggregate(DateTime start, DateTime end, int entries) {
-      using (var pm = PersistenceManager) {
-        var factClientInfoDao = pm.FactClientInfoDao;
-        var dimTimeDao = pm.DimTimeDao;
-        var clientIds = pm.UseTransaction(() => factClientInfoDao.GetAll()
-          .Where(x => x.Time >= start && x.Time <= end)
-          .Select(x => x.ClientId)
-          .Distinct()
-        );
-        foreach (var id in clientIds) {
-          AggregateClient(pm, id, start, end, entries);
-        }
-        dimTimeDao.DeleteUnusedTimes();
+      var pm = PersistenceManager;
+      var factClientInfoDao = pm.FactClientInfoDao;
+      var dimTimeDao = pm.DimTimeDao;
+      var clientIds = pm.UseTransaction(() => factClientInfoDao.GetAll()
+        .Where(x => x.Time >= start && x.Time <= end)
+        .Select(x => x.ClientId)
+        .Distinct()
+      );
+      foreach (var id in clientIds) {
+        AggregateClient(pm, id, start, end, entries);
       }
+      dimTimeDao.DeleteUnusedTimes();
     }