Changeset 12767 for branches/HiveStatistics/sources/HeuristicLab.Services.WebApp.Maintenance/3.3/WebApi

Timestamp:

07/16/15 12:31:59 (9 years ago)

Author:

dglaser

Message:

#2429:

• Improved FactClientInfo aggregation
• Added input field to specify how many entries should be aggregated

File:

• branches/HiveStatistics/sources/HeuristicLab.Services.WebApp.Maintenance/3.3/WebApi/FactClientInfoController.cs (modified) (1 diff)

branches/HiveStatistics/sources/HeuristicLab.Services.WebApp.Maintenance/3.3/WebApi/FactClientInfoController.cs

@@ -65 +65 @@
       var factClientInfoDao = pm.FactClientInfoDao;
       var clientInfos = pm.UseTransaction(() => factClientInfoDao.GetByClientId(clientId).OrderBy(x => x.Time).ToList());
-      FactClientInfo lastClientInfo = null, sumClientInfo = new FactClientInfo();
-      int counter = 0;
-      var aggregatedClientInfos = new List<FactClientInfo>();
-      foreach (var clientInfo in clientInfos) {
-        if (lastClientInfo != null) {
-          if (lastClientInfo.SlaveState != clientInfo.SlaveState ||
-              lastClientInfo.IsAllowedToCalculate != clientInfo.IsAllowedToCalculate) {
-            // update into 'lastClientInfo'
-            if (aggregatedClientInfos.Any()) {
-              counter = aggregatedClientInfos.Count();
-              pm.UseTransaction(() => {
-                factClientInfoDao.Delete(aggregatedClientInfos);
-                lastClientInfo.NumUsedCores = sumClientInfo.NumUsedCores / counter;
-                lastClientInfo.NumTotalCores = sumClientInfo.NumTotalCores / counter;
-                lastClientInfo.UsedMemory = sumClientInfo.UsedMemory / counter;
-                lastClientInfo.TotalMemory = sumClientInfo.TotalMemory / counter;
-                lastClientInfo.CpuUtilization = sumClientInfo.CpuUtilization / counter;
-                lastClientInfo.IdleTime = sumClientInfo.IdleTime;
-                lastClientInfo.OfflineTime = sumClientInfo.OfflineTime;
-                lastClientInfo.UnavailableTime = sumClientInfo.UnavailableTime;
-                pm.SubmitChanges();
-              });
-            }
-            aggregatedClientInfos.Clear();
-            counter = 0;
-            sumClientInfo = new FactClientInfo();
-          } else {
-            // sum up 
-            sumClientInfo.NumUsedCores += clientInfo.NumUsedCores;
-            sumClientInfo.NumTotalCores += clientInfo.NumTotalCores;
-            sumClientInfo.UsedMemory += clientInfo.UsedMemory;
-            sumClientInfo.TotalMemory += clientInfo.TotalMemory;
-            sumClientInfo.CpuUtilization += clientInfo.CpuUtilization;
-            sumClientInfo.IdleTime += clientInfo.IdleTime;
-            sumClientInfo.OfflineTime += clientInfo.OfflineTime;
-            sumClientInfo.UnavailableTime += clientInfo.UnavailableTime;
-            counter++;
-            if (counter >= entries) {
-              pm.UseTransaction(() => {
-                factClientInfoDao.Delete(aggregatedClientInfos);
-                clientInfo.NumUsedCores = sumClientInfo.NumUsedCores / counter;
-                clientInfo.NumTotalCores = sumClientInfo.NumTotalCores / counter;
-                clientInfo.UsedMemory = sumClientInfo.UsedMemory / counter;
-                clientInfo.TotalMemory = sumClientInfo.TotalMemory / counter;
-                clientInfo.CpuUtilization = sumClientInfo.CpuUtilization / counter;
-                clientInfo.IdleTime = sumClientInfo.IdleTime;
-                clientInfo.OfflineTime = sumClientInfo.OfflineTime;
-                clientInfo.UnavailableTime = sumClientInfo.UnavailableTime;
-                pm.SubmitChanges();
-              });
-              aggregatedClientInfos.Clear();
-              counter = 0;
-              sumClientInfo = new FactClientInfo();
-            } else {
-              aggregatedClientInfos.Add(clientInfo);
-            }
-          }
+      var e = clientInfos.GetEnumerator();
+      if (!e.MoveNext()) return;
+      do {
+        var infosToAggregate = new List<FactClientInfo> { e.Current };
+        var prev = e.Current;
+        while (infosToAggregate.Count() != entries && e.MoveNext()) {
+          var cur = e.Current;
+          if (prev.IsAllowedToCalculate != cur.IsAllowedToCalculate || prev.SlaveState != cur.SlaveState)
+            break;
+          infosToAggregate.Add(cur);
+          prev = cur;
         }
-        lastClientInfo = clientInfo;
+        if (infosToAggregate.Count() == entries) {
+          AggregateClientInfos(pm, infosToAggregate);
+        }
+      } while (e.MoveNext());
+    }
+
+    private void AggregateClientInfos(IPersistenceManager pm, List<FactClientInfo> clientInfos) {
+      var factClientInfoDao = pm.FactClientInfoDao;
+      var last = clientInfos.Last();
+      var infos = clientInfos.GroupBy(x => x.ClientId).Select(x => new {
+        NumUsedCores = (int)x.Average(y => y.NumUsedCores),
+        NumTotalCores = (int)x.Average(y => y.NumTotalCores),
+        UsedMemory = (int)x.Average(y => y.UsedMemory),
+        TotalMemory = (int)x.Average(y => y.TotalMemory),
+        CpuUtilization = Math.Round(x.Average(y => y.CpuUtilization), 2),
+        IdleTime = x.Sum(y => y.IdleTime),
+        OfflineTime = x.Sum(y => y.OfflineTime),
+        UnavailableTime = x.Sum(y => y.UnavailableTime)
+      }).SingleOrDefault();
+      if (infos != null) {
+        pm.UseTransaction(() => {
+          last.NumUsedCores = infos.NumUsedCores;
+          last.NumTotalCores = infos.NumTotalCores;
+          last.UsedMemory = infos.UsedMemory;
+          last.TotalMemory = infos.TotalMemory;
+          last.CpuUtilization = infos.CpuUtilization;
+          last.IdleTime = infos.IdleTime;
+          last.OfflineTime = infos.OfflineTime;
+          last.UnavailableTime = infos.UnavailableTime;
+          clientInfos.Remove(last);
+          factClientInfoDao.Delete(clientInfos);
+          pm.SubmitChanges();
+        });
       }
     }