Changeset 1160 for trunk/sources/HeuristicLab.Hive.Server.Core/ClientCommunicator.cs

Timestamp:

01/21/09 16:22:25 (15 years ago)

Author:

msteinbi

Message:

Implementing Lifecycle Management (#453)

File:

• trunk/sources/HeuristicLab.Hive.Server.Core/ClientCommunicator.cs (modified) (5 diffs)

trunk/sources/HeuristicLab.Hive.Server.Core/ClientCommunicator.cs

@@ -80 +80 @@
     void lifecycleManager_OnServerHeartbeat(object sender, EventArgs e) {
       List<ClientInfo> allClients = new List<ClientInfo>(clientAdapter.GetAll());
-      List<Job> allJobs = new List<Job>(jobAdapter.GetAll());
 
       foreach (ClientInfo client in allClients) {
@@ -89 +88 @@
             client.State = State.offline;
             clientAdapter.Update(client);
+            foreach (Job job in jobAdapter.GetJobsOf(client)) {
+              jobManager.ResetJobsDependingOnResults(job);
+            }
           } else {
             DateTime lastHbOfClient = lastHeartbeats[client.ClientId];
@@ -98 +100 @@
               if (client.State == State.calculating) {
                 // check wich job the client was calculating and reset it
-                foreach (Job job in allJobs) {
-                  if (job.Client.ClientId == client.ClientId) {
-                    jobManager.ResetJobsDependingOnResults(job);
-                  }
+                foreach (Job job in jobAdapter.GetJobsOf(client)) {
+                  jobManager.ResetJobsDependingOnResults(job);
                 }
               }
@@ -195 +195 @@
 
       if (hbData.jobProgress != null) {
+        List<Job> jobsOfClient = new List<Job>(jobAdapter.GetJobsOf(clientAdapter.GetById(hbData.ClientId)));
+        if (jobsOfClient == null || jobsOfClient.Count == 0) {
+          response.Success = false;
+          response.StatusMessage = ApplicationConstants.RESPONSE_COMMUNICATOR_JOB_IS_NOT_BEEING_CALCULATED;
+          return response;
+        }
+
         foreach (KeyValuePair<long, double> jobProgress in hbData.jobProgress) {
           Job curJob = jobAdapter.GetById(jobProgress.Key);
-          curJob.Percentage = jobProgress.Value;
-          jobAdapter.Update(curJob);
+          if (curJob.Client == null || curJob.Client.ClientId != hbData.ClientId) {
+            response.Success = false;
+            response.StatusMessage = ApplicationConstants.RESPONSE_COMMUNICATOR_JOB_IS_NOT_BEEING_CALCULATED;
+          } else {
+            curJob.Percentage = jobProgress.Value;
+            jobAdapter.Update(curJob);
+          }
         }
       }
@@ -228 +240 @@
         response.Success = true;
         response.StatusMessage = ApplicationConstants.RESPONSE_COMMUNICATOR_JOB_PULLED;
-        return response;
+      } else {
+        response.Success = true;
+        response.StatusMessage = ApplicationConstants.RESPONSE_COMMUNICATOR_NO_JOBS_LEFT;
       }
 
       jobLock.ReleaseMutex();
-
-      response.Success = true;
-      response.StatusMessage = ApplicationConstants.RESPONSE_COMMUNICATOR_NO_JOBS_LEFT;
+      /// End Critical section ///
+
       return response;
     }