Changeset 10506 for trunk/sources/HeuristicLab.HLScript.Views/3.3/VariableStoreView.cs

Timestamp:

02/25/14 13:55:01 (10 years ago)

Author:

jkarder

Message:

#2136: applied some of the changes suggested in comment:11:ticket:2136

• change namespaces to HeuristicLab.Scripting.*
• added extra compile button and registered F6 as a shortcut
• changed the order of the output window and the error list
• tabs (output window and error list) are selected automatically
• thrown exceptions are shown using the PluginInfrastructure
• removed namespace declaration in the script
• names in the VariableStore are now conform to C# property names

File:

• trunk/sources/HeuristicLab.HLScript.Views/3.3/VariableStoreView.cs (modified) (5 diffs)

trunk/sources/HeuristicLab.HLScript.Views/3.3/VariableStoreView.cs

@@ -1 +1 @@
 #region License Information
 /* HeuristicLab
- * Copyright (C) 2002-2013 Heuristic and Evolutionary Algorithms Laboratory (HEAL)
+ * Copyright (C) 2002-2014 Heuristic and Evolutionary Algorithms Laboratory (HEAL)
  *
  * This file is part of HeuristicLab.
@@ -25 +25 @@
 using System.Drawing;
 using System.Linq;
+using System.Text.RegularExpressions;
 using System.Windows.Forms;
 using HeuristicLab.Collections;
@@ -36 +37 @@
 using HeuristicLab.PluginInfrastructure;
 
-namespace HeuristicLab.HLScript.Views {
+namespace HeuristicLab.Scripting.Views {
   [View("ItemCollection View")]
   [Content(typeof(VariableStore), true)]
@@ -288 +289 @@
     }
 
+    private readonly Regex SafeVariableNameRegex = new Regex("^[@]?[_a-zA-Z][_a-zA-Z0-9]*$");
     private void variableListView_AfterLabelEdit(object sender, LabelEditEventArgs e) {
-      if (!string.IsNullOrEmpty(e.Label)) {
+      string name = e.Label;
+      if (!string.IsNullOrEmpty(name) && SafeVariableNameRegex.IsMatch(name)) {
         var variable = (KeyValuePair<string, object>)variableListView.Items[e.Item].Tag;
-        if (!Content.ContainsKey(e.Label)) {
+        if (!Content.ContainsKey(name)) {
           Content.Remove(variable.Key);
-          Content.Add(e.Label, variable.Value);
+          Content.Add(name, variable.Value);
         }
       }
@@ -390 +393 @@
     }
     protected virtual void AdjustListViewColumnSizes() {
-      if (variableListView.Items.Count > 0) {
-        for (int i = 0; i < variableListView.Columns.Count; i++)
-          variableListView.Columns[i].AutoResize(ColumnHeaderAutoResizeStyle.ColumnContent);
-      }
+      foreach (ColumnHeader ch in variableListView.Columns)
+        ch.Width = -2;
     }
     protected virtual void RebuildImageList() {