Ticket #1870 (closed defect: done)

Opened 11 months ago

Last modified 11 months ago

StringConvertibleArrayView does not fully paste all values

Reported by: abeham Owned by: abeham
Priority: medium Milestone: HeuristicLab 3.3.7
Component: Data.Views Version: 3.3.7
Keywords: Cc:

Description

Also I noticed that StringConvertibleMatrixView can be slow when pasting from external applications because the matrix' columns and rows are increased one by one which results in lots of memory allocations.

Change History

comment:1 Changed 11 months ago by abeham

  • Owner changed from swagner to abeham
  • Status changed from new to accepted

comment:2 Changed 11 months ago by abeham

  • Owner changed from abeham to gkronber
  • Status changed from accepted to reviewing

r7984:

  • Added a check to remove the last newline only when there's actually a newline at the end
  • Improved speed of StringConvertibleMatrixView with respect to paste operations that would extend the number of rows and columns

comment:3 Changed 11 months ago by mkommend

  • Owner changed from gkronber to abeham
  • Status changed from reviewing to assigned

Reviewed changes in r7984 - thanks for correcting this.

One remark: Shouldn't the SplitClipboardString in the StringConvertibleMatrixView also be adapted in the same way so that all vales are pasted?

comment:4 Changed 11 months ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from assigned to reviewing

Certainly!

r7987: fixed clipboard pasting in StringConvertibleMatrixView

comment:5 Changed 11 months ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from reviewing to readytorelease

comment:6 Changed 11 months ago by mkommend

  • Status changed from readytorelease to closed
  • Version changed from 3.3.6 to 3.3.7
  • Resolution set to done
Note: See TracTickets for help on using tickets.