Free cookie consent management tool by TermsFeed Policy Generator

Changes between Initial Version and Version 1 of Ticket #2762, comment 14


Ignore:
Timestamp:
07/11/17 22:32:34 (7 years ago)
Author:
mkommend
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2762, comment 14

    initial v1  
     1Reviewed all changes.
    12== Review comments ==
     3
    24=== Extreme Point Decoders ===
    35* Static methods would increase the reusability, though I don't know if that is necessary.
    … …  
    1618* Maybe an abstract base class that handles all the file handling and a configured realistic class would help.
    1719
    18 TBC
    19 * ExtremePointAlgorithm
    20 * BinPacking3D
     20=== ExtremePointAlgorithm ===
     21* Class should be sealed.
     22* Fields for Parameters should be made readonly.
     23* Wouldn't it be better to use ResultParameters?
     24* A description for the results would be helpful.