Opened 2 weeks ago

Last modified 10 days ago

#2746 reviewing defect

Overflow issues in binomial coefficient calculation

Reported by: bburlacu Owned by: bburlacu
Priority: medium Milestone: HeuristicLab 3.3.15
Component: Common Version: 3.3.14
Keywords: Cc:

Description

The EnumerableExtensions.BinomialCoefficient(n,k) method may silently overflow (for large n and k) returning the wrong results. This method should fail with an exception if the result is outside the long range.

Change History (5)

comment:1 Changed 2 weeks ago by bburlacu

  • Status changed from new to accepted

comment:2 Changed 2 weeks ago by bburlacu

  • Owner changed from bburlacu to mkommend
  • Status changed from accepted to reviewing

comment:3 Changed 2 weeks ago by bburlacu

r14750: Enable explicit overflow checking in binomial coefficient calculation.

comment:4 Changed 2 weeks ago by mkommend

  • Status changed from reviewing to readytorelease

comment:5 Changed 10 days ago by mkommend

  • Owner changed from mkommend to bburlacu
  • Status changed from readytorelease to reviewing

r14769: Made combinations extension methods thread-safe by avoiding lazy evaluation linq queries.

Note: See TracTickets for help on using tickets.