Opened 7 months ago

Last modified 2 weeks ago

#2698 readytorelease enhancement

Multi-Scatterplot in Preprocessing crashes HL with high number of variables

Reported by: pfleck Owned by: gkronber
Priority: medium Milestone: HeuristicLab 3.3.15
Component: DataPreprocessing.Views Version: 3.3.14
Keywords: Cc:

Description

Because the number of charts in the multi-scatterplot scales quadratic with the number of variables, a high number of variables causes HL to crash (limitation of system-handles).

To limit the displayed variables, a list of checkable variables should be displayed, such as in the linechart and histogram. If the number of pre-checked variables is exceeding a certain threshold (on opening the chart first time), the user should be asked if he really wishes to display all variables, risking HL to crash, or wishes to only pre-check a limited number of variables.

Furthermore, the list of checkable variables should take the allowed input variables of the problem data into account; for visual highlighting and functionality to only check allowed input variables and the (optional) target variable.

Change History (16)

comment:1 Changed 7 months ago by pfleck

r14381

  • Refactored CheckedVariablesView out of the ChartView to allow reuse of the checked variables list.
    • The new list visualizes the non-input/target variables in gray.
    • Added context menu to quickly (un)check all variables or only the inputs+target variables.
  • In the Multi-Scatterplot
    • New structure and layout of the single charts to support fixed header rows and columns (for the variable names). Instead, removed the legend of each plot for better usage of plot area.
    • Adapted the new CheckedVariablesView (but hidden until (un)checking is implemented).

comment:2 Changed 7 months ago by pfleck

r14382 Forgot to uncomment abstract keyword.

comment:3 Changed 7 months ago by pfleck

  • Status changed from new to accepted

comment:4 Changed 7 months ago by pfleck

r14384 Implemented unchecking of variables in multi-scatterplot.

comment:5 Changed 7 months ago by pfleck

r14388

  • Implemented (re)checking of variables in multi-scatterplot.
  • Added 2 sliders for changing the chart size.

comment:6 Changed 6 months ago by pfleck

r14418 Only input and target variables are pre-checked for linechart, histrogram and scatterplot.

comment:7 Changed 6 months ago by pfleck

r14425 Fixed wrongly formated variable-entries in checked item list.

comment:8 Changed 6 months ago by pfleck

  • Owner changed from pfleck to mkommend
  • Status changed from accepted to reviewing

comment:9 Changed 6 months ago by gkronber

  • Owner changed from mkommend to pfleck
  • Status changed from reviewing to assigned

Please include all files (PreprocessingCheckedVariablesView.cs?) in the project.

comment:10 Changed 5 months ago by pfleck

  • Owner changed from pfleck to mkommend
  • Status changed from assigned to reviewing

I did not find any non-included files. PreprocessingCheckedVariablesView.cs is already included in the project.

comment:11 Changed 5 months ago by mkommend

  • Owner changed from mkommend to pfleck
  • Status changed from reviewing to assigned

Reviewed and tested the functionality of the ScatterPlotMultiView.

Review comments

  • Maximum of 20 variables should be selected by default.
  • All controls should be displayed (variable check box, slider, ...) before the charts are drawn (asynchronously?).
  • One slider for the chart size is sufficient. It is quite cumbersome to handle two sliders.(r14917) The point size should also be adapted when the chart size changes.
  • Possible leak (memory, window handles). Removed controls are not disposed.
  • Inserting and removing charts is quite ugly and pretty slow. Another possibility would be to set the column / row width to 0. Maybe that is a "better" solution.
Last edited 3 weeks ago by pfleck (previous) (diff)

comment:12 Changed 3 weeks ago by gkronber

The improved multi-scatterplot is nice!

comment:13 Changed 3 weeks ago by pfleck

  • Status changed from assigned to reviewing

comment:14 Changed 3 weeks ago by pfleck

  • Owner changed from pfleck to gkronber
  • Status changed from reviewing to readytorelease

Because the Preprocessing Enhancements branch (#2709) was created after the changes of this ticket, I suggest we release this ticket and implement the review comments in #2709 to avoid potential merge conflicts.

comment:16 Changed 2 weeks ago by gkronber

r14963: merged r14381 r14382 r14384 r14388 r14418 r14425 from trunk to stable

comment:17 Changed 2 weeks ago by gkronber

r14917 (see comment:11) has not been merged as this is seemingly tracking in another ticket (#2709).

Note: See TracTickets for help on using tickets.