Opened 10 months ago

Last modified 9 days ago

#2695 accepted enhancement

Line charts for regression should show an ID column along the x-axis

Reported by: gkronber Owned by: gkronber
Priority: medium Milestone: HeuristicLab 3.3.16
Component: Problems.DataAnalysis.Symbolic.Regression.Views Version: branch
Keywords: Cc:

Description (last modified by mkommend)

For instance if the data are ordered by time the time should be shown on the x-axis

Change History (9)

comment:1 Changed 10 months ago by mkommend

  • Description modified (diff)
  • Summary changed from Line charts for regression should show an ID column along the y-axis to Line charts for regression should show an ID column along the x-axis

comment:2 Changed 3 months ago by gkronber

  • Milestone changed from HeuristicLab 3.3.15 to HeuristicLab 3.3.x Backlog

comment:3 Changed 3 weeks ago by gkronber

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.16
  • Owner set to gkronber
  • Status changed from new to accepted

comment:4 Changed 3 weeks ago by gkronber

  • Version changed from 3.3.14 to branch

comment:5 Changed 3 weeks ago by gkronber

r15296: created a feature branch from the trunk

comment:6 Changed 3 weeks ago by gkronber

r15297: added a parameter to DataAnalysisProblemData to select an id column and extended RegressionLinechartViewBase to show the id on the xAxis

comment:7 Changed 3 weeks ago by gkronber

r15298: removed commented code and unused usings

comment:8 Changed 2 weeks ago by mkommend

Comments:

  • The branch does not compile on my machine (Errors in simulated annealing)
  • -> Could not test the implemented feature
  • IDataAnalysisProblemData & DataAnalysisProblemData
    • IMO IdVariable looks and sounds strange. What about IdentificationVariable, Identification, LabelVariable, ....
    • Why not programmatic setter for the IdVariable? I know it is cumbersome to set constrained value parameters by code, but it is even more so when no setter property is provided.
    • AllIds, TrainingIds, and TestIds could be unified by using a new method GetIds(IEnumerable<int> rows)
    • Why are only features with unique values for every row allowed?
    • Ids should only be reset if the dataset changes on not if the partitions are updated
    • Is it possible to change the ID after solution creation (e.g. for updating the labels in a line chart) or is this not considered?

Code in LineChartBase looks reasonable. However, all other views should be updated as well (EstimatedValuesView).

comment:9 Changed 9 days ago by gkronber

r15310: merged r15299:15302 from trunk to branch

Note: See TracTickets for help on using tickets.