Opened 16 months ago

Last modified 8 months ago

#2547 accepted defect

Unify implementation patterns in OKB service clients

Reported by: abeham Owned by: abeham
Priority: medium Milestone: HeuristicLab 3.3.15
Component: Clients.OKB Version: 3.3.13
Keywords: Cc:

Description

The QueryClient uses singleton in combination with instance methods to perform service calls. The AdministrationClient uses a combination of singleton pattern and static methods to perform service calls.

To me it seems that the client provides the following functionality:

  1. Caching some data obtained from the remote service (in the format in that it is obtained from the service) - implemented in form of a Refresh() method on a singleton instance and properties for the data.
  2. Making calls to the remote service to receive further data (that is not cached) - implemented in form of static or instance methods.

The design may be improved if these cases are separated in two classes.

Change History (2)

comment:1 Changed 16 months ago by abeham

  • Owner set to abeham
  • Status changed from new to accepted

r13474: moved code to convert between okbitems and hlitems from view to content

comment:2 Changed 8 months ago by abeham

  • Milestone changed from HeuristicLab 3.3.14 to HeuristicLab 3.3.15
Note: See TracTickets for help on using tickets.