#2489 closed defect (done)

Cloning of the ModifiableDataset does not clone the values

Reported by: bburlacu Owned by: mkommend
Priority: medium Milestone: HeuristicLab 3.3.13
Component: Problems.DataAnalysis Version: 3.3.12
Keywords: Cc:

Description

Since the original dataset was designed to be a readonly object with immutable data, cloning was implemented such that the actual values contained in the dataset are not copied but passed by reference. This causes undesirable side-effects when the values are allowed to be changed in the ModifiableDataset.

Change History (7)

comment:1 Changed 22 months ago by bburlacu

  • Owner set to bburlacu
  • Status changed from new to accepted

comment:2 Changed 21 months ago by bburlacu

r13027: Clone values in the ModifiableDataset.

comment:3 Changed 21 months ago by bburlacu

  • Owner changed from bburlacu to mkommend
  • Status changed from accepted to reviewing

comment:4 Changed 21 months ago by mkommend

  • Owner changed from mkommend to bburlacu
  • Status changed from reviewing to assigned

Reviewed r13027.

What about string values in the modifiable dataset? Throw an exception if a not supported type is encountered to indicate the missing implementation.

comment:5 Changed 21 months ago by bburlacu

  • Owner changed from bburlacu to mkommend
  • Status changed from assigned to reviewing

r13040: Added cloning of string values and exception when an unknown variable type is encountered.

comment:6 Changed 21 months ago by mkommend

  • Status changed from reviewing to readytorelease

Reviewed r13040.

comment:7 Changed 20 months ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed

r13179: Merged r13027 and r13040 into stable.

Note: See TracTickets for help on using tickets.