#2420 closed feature request (done)

Add Sim# as simulation framework to ExtLibs

Reported by: abeham Owned by: abeham
Priority: medium Milestone: HeuristicLab 3.3.12
Component: ExtLibs Version: 3.3.11
Keywords: Cc:

Description


Change History (8)

comment:1 Changed 21 months ago by abeham

  • Status changed from new to accepted

comment:2 Changed 21 months ago by abeham

r12657: Added Sim# as an ExtLib plugin

comment:3 Changed 21 months ago by abeham

  • Owner changed from abeham to ascheibe
  • Status changed from accepted to reviewing

comment:4 Changed 21 months ago by ascheibe

  • Owner changed from ascheibe to abeham
  • Status changed from reviewing to assigned

Reviewed r12657, I have the following comments:

  • The HeuristicLab.SimSharp project is missing the frame files for adding the revision to the version info
  • The name of the plugin class should be HeuristicLabSimSharpPlugin

comment:5 follow-up: Changed 21 months ago by abeham

  • Owner changed from abeham to ascheibe
  • Status changed from assigned to reviewing

I took some bad examples to copy from, Netron and DayView both have similar problems. I would question the use of .frame files for extlibs where the version number is rather fixed.

r12671: implemented review comments

comment:6 in reply to: ↑ 5 Changed 21 months ago by ascheibe

Replying to abeham:

I took some bad examples to copy from, Netron and DayView both have similar problems. I would question the use of .frame files for extlibs where the version number is rather fixed.

r12671: implemented review comments

Yes I also thought the same thing when reviewing. The revision does not add any additional information to an extlib plugin. Maybe we should stop doing this.

comment:7 Changed 21 months ago by ascheibe

  • Owner changed from ascheibe to abeham
  • Status changed from reviewing to readytorelease

Reviewed r12671, thanks, looks good. I have added the linux prebuild events in r12675 to the project file. Please also merge it into stable.

comment:8 Changed 21 months ago by abeham

  • Resolution set to done
  • Status changed from readytorelease to closed

r12732: merged 12657,12671 to stable

Note: See TracTickets for help on using tickets.