Changes between Version 4 and Version 5 of Ticket #2394, comment 12
- Timestamp:
- 06/26/15 13:59:17 (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #2394, comment 12
v4 v5 9 9 - ~~Also, to be more C# style, you could add a getter and setter for configuration which includes the logic of Configure(..) in the setter.~~ 10 10 - ~~GetController(..) method uses TryGetValue but does not react when false is returned. Because it is used in the WeAppControllerSelector.SelectController(..) method where Exceptions are thrown when errors occur, i would do the same in GetController(..) if the controller cannot be found.~~ 11 - ReloadControllers(..) should not set the name of the plugin to "Error loading assembly" when an error occurs. You could add another string to Plugin where errors can be stored and later displayed in the plugin app.11 - ~~ReloadControllers(..) should not set the name of the plugin to "Error loading assembly" when an error occurs. You could add another string to Plugin where errors can be stored and later displayed in the plugin app.~~ 12 12 13 13 ~~Global.asax.cs~~
