Opened 2 years ago

Closed 2 years ago

Last modified 23 months ago

#2394 closed task (done)

Integrate Services Web App and new Hive Status Monitor into trunk

Reported by: ascheibe Owned by: ascheibe
Priority: medium Milestone: HeuristicLab 3.3.12
Component: Hive.Server Version: 3.3.11
Keywords: Cc:

Description

Copy

  • HeuristicLab.Services.WebApp
  • HeuristicLab.Services.WebApp.Status

from HiveStatistics branch into trunk. Remove old Status page from trunk.

Change History (33)

comment:1 Changed 2 years ago by ascheibe

  • Status changed from new to accepted

comment:2 Changed 2 years ago by ascheibe

r12428 added web app and status page to trunk

comment:3 Changed 2 years ago by ascheibe

  • Owner changed from ascheibe to dglaser
  • Status changed from accepted to assigned

comment:4 Changed 2 years ago by ascheibe

r12429 added missing package config

comment:5 Changed 2 years ago by ascheibe

r12430 added missing package config

comment:6 Changed 2 years ago by dglaser

  • Status changed from assigned to accepted

comment:7 Changed 2 years ago by dglaser

r12435: Improved PluginManager and updated hive status monitor.

comment:8 Changed 2 years ago by ascheibe

r12442 added nuget folders to svn ignore list

comment:9 Changed 2 years ago by dglaser

r12443: Fixed UserTaskQuery and GetStatusHistory in the WebApp.Status plugin

comment:10 Changed 2 years ago by dglaser

r12445:

  • Changed Web.config compilation from debug to release to force script bundling.
  • Changed history loading type from lazy to eager loading to increase performance.
  • Fixed "getCoreStatus" typo in statusCtrl.js
Last edited 2 years ago by dglaser (previous) (diff)

comment:11 Changed 2 years ago by ascheibe

  • Owner changed from dglaser to ascheibe
  • Status changed from accepted to reviewing

comment:12 Changed 2 years ago by ascheibe

Review comments for HeuristicLab.Services.WebApp-3.3:

PluginManager.cs

  • replace '\\' with Path.PathSeparator
  • replace GetPlugins(..) method with an getter 'Plugins'

Plugin.cs

  • The Plugin class should have a constructor that takes the name, the directory and the configuration as it is often used in the same way: Create new plugin and then call Configure (..) with the configuration.
  • Also, to be more C# style, you could add a getter and setter for configuration which includes the logic of Configure(..) in the setter.
  • GetController(..) method uses TryGetValue but does not react when false is returned. Because it is used in the WeAppControllerSelector.SelectController(..) method where Exceptions are thrown when errors occur, i would do the same in GetController(..) if the controller cannot be found.
  • ReloadControllers(..) should not set the name of the plugin to "Error loading assembly" when an error occurs. You could add another string to Plugin where errors can be stored and later displayed in the plugin app.

Global.asax.cs

  • give class a proper name, e.g. HeuristicLabWebApp
  • add license header

Project

  • Do we need 2 Web.config files? One is in the root directory and one in the WebApp directory. Can we merge them?

app.css

  • Remove commented out code at the top

Documentation

Last edited 2 years ago by dglaser (previous) (diff)

comment:13 Changed 2 years ago by ascheibe

  • Owner changed from ascheibe to dglaser
  • Status changed from reviewing to assigned

comment:14 Changed 2 years ago by dglaser

r12514:

HeuristicLab.Services.WebApp-3.3:

  • implemented review comments
  • fixed a bug which caused the sidebar menu to collapse on non mobile devices

HeuristicLab.Services.WebApp.Status-3.3:

  • fixed calculating cores

comment:15 Changed 2 years ago by dglaser

r12517: Removed unused code

comment:16 Changed 2 years ago by dglaser

r12519:

HeuristicLab.Services.WebApp.Status-3.3:

  • added apply button to history page
  • removed zoom and pan from history charts

comment:17 Changed 2 years ago by dglaser

r12520:

HeuristicLab.Services.WebApp-3.3:

  • changed the menu controller to set all parents of an entry to active

comment:18 Changed 2 years ago by dglaser

r12521:

HeuristicLab.Services.WebApp.Status-3.3:

  • changed the DataController to return memory in kb instead of gb
  • fixed the memory rounding error

comment:19 Changed 2 years ago by dglaser

r12523:

HeuristicLab.Services.WebApp-3.3:

  • added exception property
  • added an icon and exception message in the plugin app

comment:20 Changed 2 years ago by ascheibe

r12532

  • deleted old Hive status page
  • fixed nuget package restoration

comment:21 Changed 2 years ago by ascheibe

r12542 fixed nuget targets file

comment:22 Changed 2 years ago by dglaser

r12546:

HeuristicLab.Services.WebApp.Status:

  • added used / total cores
  • moved kb to gb filter to WebApp
  • updated nuget packages

HeuristicLab.Services.WebApp:

  • added about page
  • added filter
  • updated nuget packages
Last edited 2 years ago by dglaser (previous) (diff)

comment:23 Changed 2 years ago by dglaser

r12552: Updated project files.

comment:24 Changed 2 years ago by dglaser

r12553: Added missing plugin controller.

Last edited 2 years ago by dglaser (previous) (diff)

comment:25 Changed 2 years ago by dglaser

r12556:

HeuristicLab.Services.WebApp-3.3:

  • changed login error message
  • updated about page

comment:26 Changed 2 years ago by dglaser

r12557:

HeuristicLab.Services.WebApp-3.3:

  • added angular-tablesort library
  • added sorting functionality to plugins page

HeuristicLab.Services.WebApp.Status-3.3:

  • changed sorting

comment:27 Changed 2 years ago by dglaser

r12559: Updated HeuristicLab.Services.WebApp-3.3 project file

comment:28 Changed 2 years ago by dglaser

r12561: Changed CPU Utilization Chart

comment:29 Changed 2 years ago by ascheibe

  • Owner changed from dglaser to ascheibe
  • Status changed from assigned to reviewing

comment:30 Changed 2 years ago by ascheibe

  • Status changed from reviewing to readytorelease

Reviewed all changes, thanks!

comment:31 Changed 2 years ago by ascheibe

I'm merging the commits (r12146,r12457) from #2353 with this ticket as #2353 got obsolete with the creation of the new web app.

comment:32 Changed 2 years ago by ascheibe

  • Resolution set to done
  • Status changed from readytorelease to closed

comment:33 Changed 23 months ago by abeham

Please document the published URL somewhere, I had to guess it...

Note: See TracTickets for help on using tickets.