Opened 3 years ago

Closed 21 months ago

#2298 closed enhancement (done)

Add execution time to scripts

Reported by: jkarder Owned by: mkommend
Priority: medium Milestone: HeuristicLab 3.3.13
Component: Scripting Version: 3.3.12
Keywords: Cc:

Description


Change History (19)

comment:1 Changed 3 years ago by jkarder

  • Milestone changed from HeuristicLab 3.3.11 to HeuristicLab 3.3.12
  • Version changed from 3.3.10 to 3.3.11

comment:2 Changed 2 years ago by jkarder

  • Milestone changed from HeuristicLab 3.3.12 to HeuristicLab 3.3.13

comment:3 Changed 22 months ago by jkarder

  • Status changed from new to accepted
  • Version changed from 3.3.11 to 3.3.12

comment:4 Changed 22 months ago by jkarder

r13024: added execution time to CSharpScript

comment:5 Changed 22 months ago by jkarder

  • Owner changed from jkarder to mkommend
  • Status changed from accepted to reviewing

comment:6 Changed 22 months ago by mkommend

  • Owner changed from mkommend to jkarder
  • Status changed from reviewing to assigned

comment:7 Changed 22 months ago by jkarder

  • Status changed from assigned to accepted

comment:8 Changed 22 months ago by jkarder

r13080: added ExecutableScript and ExecutableScriptView

comment:9 Changed 22 months ago by jkarder

  • Owner changed from jkarder to mkommend
  • Status changed from accepted to reviewing

comment:10 Changed 22 months ago by mkommend

  • Owner changed from mkommend to jkarder
  • Status changed from reviewing to assigned

Please make the display of the execution time more appealing.

comment:11 Changed 21 months ago by jkarder

  • Status changed from assigned to accepted

comment:12 Changed 21 months ago by jkarder

r13138: made execution time more appealing

comment:13 Changed 21 months ago by jkarder

  • Owner changed from jkarder to mkommend
  • Status changed from accepted to reviewing

comment:14 Changed 21 months ago by mkommend

  • Owner changed from mkommend to jkarder
  • Status changed from reviewing to assigned

Review Comments

for r13080 and r13138

  • Script
    • Virtual member call in ctor (CodeTemplate)! Is this necessary?
    • I would suggest to remove the virtual modifier from the CodeTemplate and make it private instead.
    • CodeProvider: Why has the Script class a CSharpCodeProvider property? Isn't Script language agnostic?
    • Should Script be abstract?
  • ExecuteableScript
    • Execute should dispose the timer.
    • Why is ExecutableScript abstract, but its base class Scipt is not?
    • Ctors for abstract classes should be protected.
    • Virtual member call in ctor (CodeTemplate)! Is this necessary?

Thanks for improving the location and display of the execution time.

comment:15 Changed 21 months ago by jkarder

  • Status changed from assigned to accepted

comment:16 Changed 21 months ago by jkarder

r13218: applied some of the changes suggested by mkommend in comment:14:ticket:2298

comment:17 Changed 21 months ago by jkarder

  • Owner changed from jkarder to mkommend
  • Status changed from accepted to reviewing

comment:18 Changed 21 months ago by mkommend

  • Status changed from reviewing to readytorelease

Reviewed r13218.

comment:19 Changed 21 months ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed

r13277: Merged r13024, r13080, r13138, and r13218 into stable.

Note: See TracTickets for help on using tickets.