Changes between Initial Version and Version 1 of Ticket #2262, comment 32
- Timestamp:
- 01/27/15 09:15:53 (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #2262, comment 32
initial v1 1 1 Reviewed r11436, r11440, r11471, r11474, r11477, r11479, r11480, r11605, r11657, r11721, r11734, r11735, r11787, r11787, r11789. 2 2 Seems ok, just 2 things: 3 - VariableStoreView.cs: Please move SafeVariableNameReges/DefaultVariableName to the top of the class.3 - ~~VariableStoreView.cs: Please move SafeVariableNameReges/DefaultVariableName to the top of the class.~~ 4 4 - As a side note for the future: I don't really understand the seperation between Script and CSharpScript. Script compiles C# code but can't really run it. CSharpScript runs C# scripts and has a variable store. I think that this should be refactored if/when we add another language. I would make Script abstract and language independent and put all language-specific stuff into classes that inherit from Script.
