Opened 3 years ago

Closed 2 years ago

#2241 closed defect (done)

ItemsRemoved event handling is incorrect in some places

Reported by: abeham Owned by: abeham
Priority: medium Milestone: HeuristicLab 3.3.11
Component: General Version: 3.3.10
Keywords: Cc:

Description (last modified by abeham)

A couple of item collection event handlers were implemented incorrectly for ItemsRemoved events. Unification in event handling would be possible if ItemsRemoved was using OldItems property to store removed items. This is described in ticket: #2297.

Here the bugs should be fixed.

Change History (8)

comment:1 Changed 3 years ago by abeham

  • Owner set to abeham
  • Status changed from new to accepted

r11346: fixed event handling

comment:2 Changed 3 years ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from accepted to reviewing

comment:3 Changed 3 years ago by mkommend

Reviewed r11346. Thx for fixing those bugs.

r11346 underlines the importance of a unified signature for collection event handlers.

comment:4 Changed 3 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from reviewing to assigned

comment:5 Changed 2 years ago by ascheibe

Please create a new ticket and set this one readytorelease.

comment:6 Changed 2 years ago by abeham

  • Description modified (diff)
  • Status changed from assigned to reviewing
  • Summary changed from ItemsRemoved event uses Items instead of OldItems to store removed items to ItemsRemoved event handling is incorrect in some places

Created new ticket.

comment:7 Changed 2 years ago by abeham

  • Status changed from reviewing to readytorelease

comment:8 Changed 2 years ago by abeham

  • Resolution set to done
  • Status changed from readytorelease to closed

r11903: merged to stable

Note: See TracTickets for help on using tickets.