Opened 3 years ago

Closed 3 years ago

#2203 closed defect (done)

VariableStore is not cloned when a CSharpScript is cloned

Reported by: jkarder Owned by: abeham
Priority: medium Milestone: HeuristicLab 3.3.10
Component: Scripting Version: 3.3.9
Keywords: Cc:

Description

In the cloning ctor of the CSharpScript class, instead of cloning the VariableStore, a new one is created.

Change History (10)

comment:1 Changed 3 years ago by jkarder

  • Status changed from new to accepted

comment:2 Changed 3 years ago by jkarder

r11056: used the persistence to clone the VariableStore

comment:3 Changed 3 years ago by jkarder

  • Owner changed from jkarder to abeham
  • Status changed from accepted to reviewing

comment:4 Changed 3 years ago by abeham

r11058: Made VariableStore IDeepCloneable and implemented cloning there

comment:5 Changed 3 years ago by abeham

  • Owner changed from abeham to jkarder

comment:6 Changed 3 years ago by jkarder

  • Owner changed from jkarder to mkommend

r11066: fixed CloneByPersistence

comment:7 follow-up: Changed 3 years ago by abeham

Wasn't it possible to use <F2> for renaming variables in the variable store?

comment:8 in reply to: ↑ 7 Changed 3 years ago by jkarder

Replying to abeham:

Wasn't it possible to use <F2> for renaming variables in the variable store?

I've never implemented this, but it would indeed be a nice usability feature.

comment:9 Changed 3 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from reviewing to readytorelease

Looks good.

comment:10 Changed 3 years ago by abeham

  • Resolution set to done
  • Status changed from readytorelease to closed

r11090: merged to stable

Note: See TracTickets for help on using tickets.