Opened 3 years ago

Closed 3 years ago

#2193 closed defect (done)

BestSolutionAnalyzer does not add a result if the best quality is not better than the best known quality

Reported by: mkommend Owned by: mkommend
Priority: medium Milestone: HeuristicLab 3.3.10
Component: Problems.ParameterOptimization Version: 3.3.9
Keywords: Cc:

Description

If the current best quality is worse than the best known quality no solution is added to the results section.

Change History (7)

comment:1 Changed 3 years ago by mkommend

  • Status changed from new to accepted

comment:2 Changed 3 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from accepted to reviewing

r10937: Fixed bug in BestSolutionAnalyzer for parameter optimization problems.

comment:3 follow-up: Changed 3 years ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from reviewing to assigned

I don't understand the change. Why did you remove the else condition in the if (improvement) branch? If there was an improvement, but no solution present you wouldn't update a solution, you'll have to wait to a point where there is no improvement at which point the result is generated.

Wouldn't it be better to check if the result exists in an independent condition before checking if there was an improvement?

comment:4 Changed 3 years ago by mkommend

r11019: Fixed bugs in BestSolutionAnalyzer for parameter optimization problems.

comment:5 in reply to: ↑ 3 Changed 3 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from assigned to reviewing

Replying to abeham:

I don't understand the change. Why did you remove the else condition in the if (improvement) branch? If there was an improvement, but no solution present you wouldn't update a solution, you'll have to wait to a point where there is no improvement at which point the result is generated.

Wouldn't it be better to check if the result exists in an independent condition before checking if there was an improvement?

Thank you for the detailed review and spotting the bugs in the analyzer.

comment:6 Changed 3 years ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from reviewing to readytorelease

ok

comment:7 Changed 3 years ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed

r11152: Merged r10937, r11019 into stable.

Note: See TracTickets for help on using tickets.