Opened 3 years ago

Closed 3 years ago

#2144 closed task (done)

Interpreter Evaluation Tests could fail if VS2013 is installed

Reported by: mkommend Owned by: mkommend
Priority: medium Milestone: HeuristicLab 3.3.11
Component: Tests Version: 3.3.9
Keywords: Cc:

Description

Currently the interpreter evaluation tests check if a tree that consists of log(-3) evaluates to double.NaN. With VS2012 Assert.AreEqual(double.NaN, double.NaN, epsilon) is true, while with VS2013 installed this evaluates to false and the assert is violated. Therefore, the unit tests should be adapted to explicitly check if both provided values are double.NaN and only otherwise evaluate the asserts.

For more information see: http://stackoverflow.com/questions/2524462/double-nan-equality-in-ms-test

Change History (4)

comment:1 Changed 3 years ago by mkommend

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.11
  • Status changed from new to accepted

comment:2 Changed 3 years ago by mkommend

  • Owner changed from mkommend to gkronber
  • Status changed from accepted to reviewing

r11430: Adapted interpreter evaluation test to explicitly check if both values (interpreted and expected) are double.NaN.

comment:3 Changed 3 years ago by gkronber

  • Owner changed from gkronber to mkommend
  • Status changed from reviewing to readytorelease

Reviewed r11430.

comment:4 Changed 3 years ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed

r11534: Merged r11430 into stable.

Note: See TracTickets for help on using tickets.