Opened 4 years ago

Closed 3 years ago

#2117 closed defect (done)

Open Hive Job Manager for more task types

Reported by: ascheibe Owned by: ascheibe
Priority: medium Milestone: HeuristicLab 3.3.10
Component: Hive.Client Version: 3.3.9
Keywords: Cc:

Description (last modified by ascheibe)

At the moment the Hive Job Manager only handles Optimizer(Hive)Tasks correctly by manually checking for them. This should be changed so that new task types (like the RunCollectionModifierHiveTasks) also work out of the box. Necessary changes:

  • RefreshableHiveJobView: The drag and drop event has to check if the dragged item has a corresponding HiveTask. If this is the case drag and drop is allowed. Up until now this is done manually by checking for e.g. IOptimizer.
  • The TaskDownloader has to generate the correct HiveTask when downloading tasks so that the correct view is then used in the Hive Job Manager.

Change History (13)

comment:1 Changed 4 years ago by ascheibe

  • Status changed from new to accepted

comment:2 Changed 4 years ago by ascheibe

  • Description modified (diff)

comment:3 Changed 4 years ago by ascheibe

r10130

  • fixed drag and drop check in the RefreshableHiveJobView to be more generic
  • fixed TaskDownloader to generate the correct HiveTasks when downloading tasks
  • fixed some variable names (job => task) which were forgotten
  • the IsParallelizable property of a task can now be set (e.g. if a task gets parallelized, the generated child tasks should sometimes not be able to get further parallelized)

comment:4 Changed 4 years ago by ascheibe

r10150

  • improved creation of ItemTasks from Items and moved common functionality to ItemTask
  • added a MenuItem for directly uploading tasks (e.g. from experiments, batchruns,...)
  • added a MenuItem for creating RefreshableHiveJobs

comment:5 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from accepted to reviewing

comment:6 Changed 4 years ago by ascheibe

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to assigned

comment:7 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from assigned to reviewing

r10154 activated automatic parallelization of batchruns in Hive

comment:8 Changed 4 years ago by ascheibe

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to assigned

comment:9 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from assigned to reviewing

r10170

  • fixed namespaces of Hive menuitems
  • fixed name of generated Hive jobs

comment:10 Changed 3 years ago by mkommend

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to assigned

Review comments

Hive MenuItems

  • The enabled property is not updated in OnActiveViewChanged, if the active view is no ContentView, or the content is null, or the view is locked (in OnActiveViewChanged).

RefreshableHiveJobView

  • Always use normal casts instead of as casts if the type of the object is already restricted. If as casts are used a null check must be performed. This is not done for example in line 470, 483, 487, 497.
  • Avoid manual creation of cloner object and use parameterless clone method(line 487).
  • Variable name hiveTaskFound does not reflect its meaning. A better name would be for example isObjTypeSupported. Another possibility would be to remove the variable completely and move the call to ItemTask.IsTypeSupported(objType) directly in the if condition.

ItemTask

  • The helper methods for task creation and existence checking are not really well designed, but they serve their purpose. If further changes are made to these, a redesign should be considered.

comment:11 Changed 3 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from assigned to reviewing

r11079 implemented review comments:

  • fixed updating of enabled state in Hive menu items
  • fixed casts in RefreshableHiveJobView
  • fixed cloning call
  • removed hiveTaskFound variable

comment:12 Changed 3 years ago by mkommend

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to readytorelease

Reviewed r11079.

comment:13 Changed 3 years ago by ascheibe

  • Resolution set to done
  • Status changed from readytorelease to closed

r11083 merged r10130, r10150, r10154, r10170, r11079 into stable

Note: See TracTickets for help on using tickets.