Implement a breadcrumb navigation for view hosts

[jkarder]

If too many nested views are created, the following exception is thrown:

System.ComponentModel.Win32Exception (0x80004005): Error creating window handle.
   at System.Windows.Forms.NativeWindow.CreateHandle(CreateParams cp)
   at System.Windows.Forms.Control.CreateHandle()
   at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
   at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
   at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
   at System.Windows.Forms.Control.CreateControl()
   at System.Windows.Forms.Control.ControlCollection.Add(Control value)
   at HeuristicLab.MainForm.WindowsForms.ViewHost.set_ActiveView(IContentView value)
   at HeuristicLab.MainForm.WindowsForms.ViewHost.OnViewTypeChanged()
   at HeuristicLab.MainForm.WindowsForms.ViewHost.set_ViewType(Type value)
   at HeuristicLab.MainForm.WindowsForms.ViewHost.OnContentChanged()
   at HeuristicLab.MainForm.WindowsForms.ContentView.set_Content(IContent value)
   at HeuristicLab.Core.Views.ItemCollectionView`1.itemsListView_SelectedIndexChanged(Object sender, EventArgs e)
   at HeuristicLab.Core.Views.ParameterCollectionView.itemsListView_SelectedIndexChanged(Object sender, EventArgs e)
   at System.Windows.Forms.ListView.WmReflectNotify(Message& m)
   at System.Windows.Forms.ListView.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Therefore, a navigation mechanism that avoids deeply nested view arrangements (e.g. breadcrumbs) should be implemented.

[jkarder]

r10041: created branch

[jkarder]

r10042: added prototype of a breadcrumb navigation

[jkarder]

r10087: fixed readonly property assignment in ParameterCollectionView

[jkarder]

r10089:

• added hotlinking functionality
• added methods for outermost view host detection and manipulation

[jkarder]

r10093:

• refactored breadcrumb navigation
• added possibility to navigate to the first invisible breadcrumb via the ellipsis

[jkarder]

r10103:

• fixed issues within the outermost control detection
• fixed visible property assignment of the breadcrumb control in ViewHost

[jkarder]

r10106:

• refactored outermost view host detection
• fixed update logic of breadcrumb trail
• fixed some views

[jkarder]

r10107: fixed logic in LinkClicked event handler

[jkarder]

I know that there are still some issues left, e.g. if you open the Hive Job Manager, the breadcrumb navigation shows the fully qualified type name of the HiveClient. It would be nice if you could have a look at the current implementation and give me some hints.

[mkommend]

Review comments:

• It should be possible to configure whether the breadcrumb navigation is used.
• It would be cool if the previously shown tab is restored, when navigating back to a previously shown view (e.g. opening an algorithm parameter and navigating back to the algorithm view shows the problem tab). However, this could be hard to implement.
• The breadcrumb navigation is not updated, when the string representation of an item changes.
• You could use the view attribute to avoid displaying the fully qualified type name (as it is the case for the Hive Job Manager).

I haven't had a detailed look at the source code and focused on the functionality for now. IMHO, the breadcrumb navigation is most useful when one doesn't work with the docking Mainform. Another issue is that breadcrumb navigation doesn't resolve the issue that too many nested views are created.

[mkommend]

Created a separate ticket for the BSOD on Win8 for too many nested views (#2158)

[jkarder]

r11591: reverted to r10041

[jkarder]

r11594: merged r10041:11593 from trunk into branch

[jkarder]

I have been following the proposals from abeham, ascheibe and mkommend and came up with a new breadcrumb prototype. I will commit the changes right to the trunk (I hope this is okay) and also delete the branch since all revisions that were committed up to this point can be ignored.

[jkarder]

r13012: deleted Breadcrumbs branch

[jkarder]

r13014: added new breadcrumb navigation prototype

[pfleck]

In the OperatorGraphView, if we use the IOperatorGraphOperator interface instead of AlgorithmOperator the breadcrumbs (and operatorgraph view) would work not only for AlgorithmOperators but for all operators that implement IOperatorGraphOperator.

I tested it locally and it worked.

See attachment:OperatorGraphView.cs.patch​

[ascheibe]

These changes are in trunk and we have not made any decision about them. From my point of view there are 2 options:

• Leave it as it is and release it
• Remove breadcrumbs from the collection views and only release it for the OperatorGraph view

What should we do?

[mkommend]

I opt for removing bread crumbs from collection views and only release them for the operator graph view.

[gkronber]

I prefer the second option (only for the OperatorGraph). We can then discuss how we would like to include this in the collection views.

[jkarder]

r13244: worked on breadcrumb navigation

• OperatorGraphView now checks for IOperatorGraphOperator instead of AlgorithmOperator
• removed breadcrumbs from collection views

[jkarder]

r13245: fixed plugin dependencies

[ascheibe]

Reviewed r13014, r13244 and r13245, all good.

[jkarder]

Thanks!

[jkarder]

r13258: merged r13014, r13244 and r13245 into stable

[ascheibe]

r13302 recorded merge info for r13258