Opened 4 years ago

Closed 4 years ago

#2100 closed enhancement (done)

Views should support displaying help texts

Reported by: ascheibe Owned by: ascheibe
Priority: medium Milestone: HeuristicLab 3.3.9
Component: MainForm.WindowsForms Version: 3.3.8
Keywords: Cc:

Description


Change History (13)

comment:1 Changed 4 years ago by ascheibe

  • Status changed from new to accepted

comment:2 Changed 4 years ago by ascheibe

r9915 added a help button to View which opens and displays help texts if a help resource path is specified in the view attribute

comment:3 Changed 4 years ago by ascheibe

r9916 added loading of txt files

comment:4 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from accepted to reviewing

comment:5 Changed 4 years ago by ascheibe

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to assigned

r9920 moved help system from View to ViewHost

comment:6 Changed 4 years ago by ascheibe

r9921 improved handling of position of help label

comment:7 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from assigned to reviewing

comment:8 Changed 4 years ago by mkommend

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to assigned

Code review comments:

InfoBox.cs

  • Remove unnecessary default ctor.
  • Remove properties for caption, embedded resource and parentView. It should be sufficient to store them in private fields.
  • Use accept button property of the form instead of an additional event handler (okButton_Click)
  • Use the form load (or a better suited event override) for the loading of embedded resources and access the defining assembly by the parent property.

comment:9 Changed 4 years ago by ascheibe

r9935 implemented review comments

comment:10 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to gkronber
  • Status changed from assigned to reviewing

comment:11 Changed 4 years ago by gkronber

  • Owner changed from gkronber to ascheibe
  • Status changed from reviewing to readytorelease

Reviewed r9935. The review comments have been implemented. Also reviewed r9915:9916 and r9920:9921.

However, I couldn't test the functionality as the trunk does not contain views that provide a help resource?

comment:12 Changed 4 years ago by ascheibe

Thanks! Yes that's right, the only views that use this functionality at the moment are the Chart Analysis view and the Statistical Testing view from the StatisticalTesting branch.

comment:13 Changed 4 years ago by ascheibe

  • Resolution set to done
  • Status changed from readytorelease to closed

r9977 merged r9915-r9916, r9920-r9921, r9935 into stable branch

Note: See TracTickets for help on using tickets.