Opened 4 years ago

Closed 4 years ago

#2079 closed enhancement (done)

StringConvertibleValueView cannot be subclassed

Reported by: mkommend Owned by: mkommend
Priority: medium Milestone: HeuristicLab 3.3.9
Component: Data.Views Version: 3.3.8
Keywords: Cc:

Description

The StringConvertibleValueView is not sealed to allow subclassing. However, all controls and events are marked as private, which practically make subclassing useless.

Change History (4)

comment:1 Changed 4 years ago by mkommend

  • Status changed from new to accepted

comment:2 Changed 4 years ago by mkommend

  • Owner changed from mkommend to ascheibe
  • Status changed from accepted to reviewing

r9664: Changed access modifiers of members in StringConvertibleValueView from private to protected to allow subclassing.

comment:3 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from reviewing to readytorelease

Reviewed r9664, looks good.

comment:4 Changed 4 years ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed

r9672: Merged r9664 into the stable branch.

Note: See TracTickets for help on using tickets.