Opened 5 years ago

Closed 4 years ago

#1959 closed enhancement (done)

The Hive JobManager should show the jobs per user sorted by date

Reported by: mkommend Owned by: ascheibe
Priority: high Milestone: HeuristicLab 3.3.8
Component: Hive.Client Version: 3.3.8
Keywords: Cc:

Description

The JobManager currently shows the job sorted alphabetically, which makes it hard to find the latest ones.

Attachments (1)

hive_sorted_jobs_view.png (42.9 KB) - added by bburlacu 4 years ago.
Hive - sorted jobs view

Download all attachments as: .zip

Change History (19)

comment:1 Changed 5 years ago by ascheibe

  • Status changed from new to accepted

comment:2 Changed 5 years ago by ascheibe

r8702 added a comparer for sorting the jobs in the Hive Job Manager by date

comment:3 Changed 5 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from accepted to reviewing

comment:4 Changed 5 years ago by mkommend

Reviewing Comments

  • Use as cast and a null check instead of is condition
  • Use DateTime.TryParse instead of catching an exception
  • Rename ListViewDataComparer to ListViewItemComparer, because it handles ListViewItems instead of ListViews and can also compares strings.
  • Why can strings and DateTimes handled correctly, but numerical values ignored? Is there a specific reason for this?
  • Is an InvalidArgumentException more appropriate than an InvalidCastException?

The functionality works perfectly, so the reviewing comments are more or less hints to further improve the code quality.

comment:5 Changed 5 years ago by mkommend

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to assigned

comment:6 Changed 5 years ago by ascheibe

r8708 implemented reviewing comments

comment:7 Changed 5 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from assigned to reviewing

Concerning your fourth comment: Handling of strings is a fallback if date conversion fails. I don't think we should also check for numerical values if date conversion fails, it would be probably better to throw an exception and remove sorting using strings?

comment:8 Changed 5 years ago by ascheibe

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to assigned

comment:9 Changed 5 years ago by ascheibe

r8718 removed string comparison

comment:10 Changed 5 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from assigned to reviewing

comment:11 Changed 5 years ago by mkommend

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to readytorelease

comment:12 Changed 4 years ago by ascheibe

  • Status changed from readytorelease to assigned

comment:13 Changed 4 years ago by ascheibe

r8850 fixed a bug which occurs on systems that don't use german time format

comment:14 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to bburlacu
  • Status changed from assigned to reviewing

@Bogdan: Could you please check if it works now for you?

Changed 4 years ago by bburlacu

Hive - sorted jobs view

comment:15 Changed 4 years ago by bburlacu

  • Owner changed from bburlacu to ascheibe
  • Status changed from reviewing to assigned

It works, yes.

Screenshot:

Hive - sorted jobs view

comment:16 Changed 4 years ago by ascheibe

  • Status changed from assigned to reviewing

Thanks, I'm setting this ticket therefore readytorelease.

comment:17 Changed 4 years ago by ascheibe

  • Status changed from reviewing to readytorelease

comment:18 Changed 4 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.7 to 3.3.8
Note: See TracTickets for help on using tickets.