Opened 5 years ago

Closed 5 years ago

#1778 closed defect (done)

Hive Items throw an Exception on ToString

Reported by: mkommend Owned by: ascheibe
Priority: medium Milestone: HeuristicLab 3.3.7
Component: Hive.General Version: 3.3.7
Keywords: Cc:

Description (last modified by mkommend)

HiveItems constructed by default ctor throw NullReferenceException in the ToString method.

 var item = new OptmizerTask();
 item.ToString() // throws exception

This happens by more than one item and so the best way would be to test the functionality in a UnitTest and correct the according classes.

Change History (10)

comment:1 Changed 5 years ago by mkommend

  • Description modified (diff)

comment:2 Changed 5 years ago by mkommend

  • Summary changed from Hive Items throw Exception on ToString to Hive Items throw an Exception on ToString

comment:3 Changed 5 years ago by ascheibe

  • Status changed from new to accepted

r7530 check if the item in ItemTask and OptimizerTask is null

comment:4 Changed 5 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from accepted to reviewing

comment:5 Changed 5 years ago by ascheibe

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to assigned

comment:6 Changed 5 years ago by ascheibe

r7532

  • tried to clean up ItemTask/EngineTask overrides without breaking anything
  • added a unit test to check if ToString methods of IItems work
  • fixed ToString method of the Hive Plugin dto

Just a quick note: The ItemTask/OptimizerTask/EngineTask classes should be refactored in the future when there is the next compatibility break in Hive. ItemTask should not inherit NamedItem as the EngineTask does not contain a NamedItem and therefore doesn't know how to implement those members appropriately.

comment:7 Changed 5 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from assigned to reviewing

comment:8 Changed 5 years ago by mkommend

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.7

comment:9 Changed 5 years ago by mkommend

  • Owner changed from mkommend to ascheibe
  • Status changed from reviewing to readytorelease

comment:10 Changed 5 years ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.6 to 3.3.7
Note: See TracTickets for help on using tickets.