Opened 6 years ago

Closed 5 years ago

#1770 closed task (done)

BestKnownQuality should not have a default value

Reported by: abeham Owned by: abeham
Priority: low Milestone: HeuristicLab 3.3.7
Component: Optimization Version: 3.3.7
Keywords: Cc: mkommend

Description

When one derives from SingleObjectiveHeuristicOptimizationProblem<TEvaluator, TSolutionCreator> the BestKnownQuality is already defined as an OptionalValueParameter<DoubleValue>. However it is also given an initial value when it is instantiated (new DoubleValue()) which is unnecessary and which cannot be known at this point in the abstraction. Any derived problem would need to clear this value again.

Change History (12)

comment:1 Changed 6 years ago by abeham

  • Owner changed from swagner to abeham
  • Status changed from new to accepted

comment:2 Changed 6 years ago by abeham

r7440

  • Removed default value of BestKnownQuality parameter

comment:3 Changed 6 years ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from accepted to reviewing

comment:4 Changed 6 years ago by abeham

r7442

  • removed protected modifier from Maximization.Set and BestKnownQuality.Set
  • fixed some parts that expected a default value

comment:5 Changed 6 years ago by abeham

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.7

comment:6 Changed 6 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from reviewing to readytorelease

Reviewed r7440 and r7442.

comment:7 Changed 5 years ago by abeham

  • Status changed from readytorelease to assigned

comment:8 Changed 5 years ago by abeham

  • Status changed from assigned to accepted

mkommend discovered that the onemax problem was broken.

comment:9 Changed 5 years ago by abeham

r7519

  • Fixed default ctor of OnemaxProblem
  • Added unit test to instantiate all creatables

comment:10 Changed 5 years ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from accepted to reviewing

comment:11 Changed 5 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from reviewing to readytorelease

comment:12 Changed 5 years ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.6 to 3.3.7
Note: See TracTickets for help on using tickets.