Opened 6 years ago

Closed 5 years ago

#1715 closed defect (done)

Type names of operators are not shown in the OperatorGraphView

Reported by: swagner Owned by: mkommend
Priority: high Milestone: HeuristicLab 3.3.6
Component: Operators.Views.OperatorGraphVisualization Version: 3.3.6
Keywords: Cc:

Description

The type names of operators are not shown in the OperatorGraphView. Therefore it is hard to identify an operator, if the operator name has been changed.

Change History (8)

comment:1 Changed 6 years ago by mkommend

  • Status changed from new to accepted

comment:2 Changed 6 years ago by mkommend

  • Owner changed from mkommend to swagner
  • Status changed from accepted to reviewing

r7199: Added type name to operator shapes.

comment:3 follow-up: Changed 6 years ago by swagner

  • Owner changed from swagner to mkommend
  • Status changed from reviewing to assigned

Thanks for implementing this feature. I reviewed the changes and have the following comments:

  • Are the setters of OperatorShape.TypeName and OperatorShapeInfo.TypeName really necessary? In my opinion the type name should not change.
  • Initializing typeName with title in OperatorShapeInfo.AfterDeserialization is critical when loading old algorithms. If the algorithm contains operators with changed names, the title of these operators is not the type name anymore. In this case OperatorShapeInfo.TypeName is set to a wrong value.
  • When setting an operator name back to the original type name, the type name string in the shape disappears as desired, but the size of the shape is not changed.
  • When changing an operator name from the original type name to something else in an expanded shape, the type name string overlaps with the string of the first parameter.

comment:4 Changed 6 years ago by mkommend

r7226: Corrected display of type names in OperatorShapes.

comment:5 in reply to: ↑ 3 Changed 6 years ago by mkommend

Replying to swagner: Changes made in r7226

  • Are the setters of OperatorShape.TypeName and OperatorShapeInfo.TypeName really necessary? In my opinion the type name should not change.

Changed the property name to subtitle, because this property can be used for other information as well. This was also the intention of the setter.

  • Initializing typeName with title in OperatorShapeInfo.AfterDeserialization is critical when loading old algorithms. If the algorithm contains operators with changed names, the title of these operators is not the type name anymore. In this case OperatorShapeInfo.TypeName is set to a wrong value.

Corrected.

  • When setting an operator name back to the original type name, the type name string in the shape disappears as desired, but the size of the shape is not changed.

Corrected.

  • When changing an operator name from the original type name to something else in an expanded shape, the type name string overlaps with the string of the first parameter.

Corrected.

comment:6 Changed 6 years ago by mkommend

  • Owner changed from mkommend to swagner
  • Status changed from assigned to reviewing

comment:7 Changed 5 years ago by swagner

  • Owner changed from swagner to mkommend
  • Status changed from reviewing to readytorelease

Great. Thanks.

comment:8 Changed 5 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.5 to 3.3.6
Note: See TracTickets for help on using tickets.