Opened 6 years ago

Closed 6 years ago

#1714 closed defect (done)

Stopping optimizers in experiments enables the wrong buttons on the experiment

Reported by: ascheibe Owned by: swagner
Priority: medium Milestone: HeuristicLab 3.3.6
Component: Optimization Version: 3.3.6
Keywords: Cc:

Description


Change History (11)

comment:1 Changed 6 years ago by ascheibe

  • Status changed from new to assigned

comment:2 Changed 6 years ago by ascheibe

r7196 stopping an optimizer or a batch run inside an experiment now enables the prepare button in the parent if there are no other running optimizers or batch runs in the experiment

comment:3 Changed 6 years ago by ascheibe

  • Owner changed from ascheibe to swagner
  • Status changed from assigned to reviewing

comment:4 Changed 6 years ago by ascheibe

  • Owner changed from swagner to ascheibe
  • Status changed from reviewing to assigned

comment:5 Changed 6 years ago by ascheibe

r7197 also take paused optimizers into account when an optimizer is stopped

comment:6 Changed 6 years ago by ascheibe

  • Owner changed from ascheibe to swagner
  • Status changed from assigned to reviewing

comment:7 Changed 6 years ago by swagner

  • Owner changed from swagner to ascheibe
  • Status changed from reviewing to assigned

Thanks. I reviewed the changes and noticed that the batch execution of optimizers in an experiment does not work anymore after the changes of r7196 and r7197. If you create an experiment with multiple optimizers and start it, the experiment is stopped after the first optimizer is stopped and the other optimizers of the experiment are not executed.

comment:8 Changed 6 years ago by ascheibe

  • Owner changed from ascheibe to swagner
  • Status changed from assigned to reviewing

r7238: reverted the changes from r7196 and r7197. If an optimizer in the experiment is stopped and there exists another prepared optimizer, the experiment is now set to prepared. This enables the correct buttons in the experiment view and the remaining optimizers can be executed.

comment:9 Changed 6 years ago by swagner

  • Owner changed from swagner to ascheibe

Thanks, but I think that the changes of r7238 are still not fully correct. I made some additional modifications in r7241. Please review these changes and test them in the UI.

comment:10 Changed 6 years ago by ascheibe

  • Owner changed from ascheibe to swagner
  • Status changed from reviewing to readytorelease

I have tested your changes, I think that works very well.

comment:11 Changed 6 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.5 to 3.3.6
Note: See TracTickets for help on using tickets.