Opened 6 years ago

Closed 6 years ago

#1604 closed enhancement (done)

DataAnalysisSolution should cache the evaluation results

Reported by: mkommend Owned by: gkronber
Priority: medium Milestone: HeuristicLab 3.3.6
Component: Problems.DataAnalysis Version: 3.3.6
Keywords: Cc:

Description

Currently the results of a DataAnalysisSolution are calculated by evaluating the model on the problem data and these evaluation results are discarded. This results can be easily cached to avoid reevaluating the same data again.

Change History (7)

comment:1 Changed 6 years ago by mkommend

  • Status changed from new to accepted

r6606: Enabled caching of evaluation results in data analysis solutions.

comment:2 Changed 6 years ago by mkommend

  • Owner changed from mkommend to gkronber
  • Status changed from accepted to reviewing

comment:3 Changed 6 years ago by gkronber

I have a small objection to the changes to DataAnalysisSolution.cs and DiscriminantFunctionClassificationSolutionBase.cs in r6606. The Design Guidelines for Developing Class Libraries states:

"Do use a parameter that is typed as the event argument class to the protected method that raises an event. The parameter should be named e."

Last edited 6 years ago by gkronber (previous) (diff)

comment:4 Changed 6 years ago by gkronber

Reviewed caching code added in r6606. Looks good, thanks for implementing this.

comment:5 Changed 6 years ago by gkronber

r7180: removed caching code for SVM models as caching of estimated values is done in the solutions now.

comment:6 Changed 6 years ago by gkronber

  • Status changed from reviewing to readytorelease

comment:7 Changed 6 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.5 to 3.3.6
Note: See TracTickets for help on using tickets.